Skip to content

build: Update googleapis version #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 5 commits into from
Aug 14, 2023
Merged

build: Update googleapis version #1736

parthea merged 5 commits into from
Aug 14, 2023

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Aug 11, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1729 🦕

@ohmayr ohmayr requested a review from a team as a code owner August 11, 2023 16:32
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 11, 2023
@snippet-bot
Copy link

snippet-bot bot commented Aug 11, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 70 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ohmayr ohmayr requested a review from parthea August 11, 2023 16:33
parthea
parthea reviewed Aug 11, 2023
View reviewed changes
@parthea parthea changed the title Chore: Update googleapis version build: Update googleapis version Aug 11, 2023
@ohmayr ohmayr force-pushed the update-googleapis-version branch from 64ab848 to 163b9c5 Compare August 11, 2023 18:21
@ohmayr ohmayr force-pushed the update-googleapis-version branch from 163b9c5 to 4d2ddb5 Compare August 11, 2023 18:23
parthea
parthea reviewed Aug 11, 2023
View reviewed changes
@parthea parthea enabled auto-merge (squash) August 14, 2023 17:06
@parthea parthea merged commit 3f46545 into main Aug 14, 2023
@parthea parthea deleted the update-googleapis-version branch August 14, 2023 17:07
parthea added a commit that referenced this pull request Sep 2, 2023
@parthea
update goldens after update in #1736
1a67d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

@ohmayr ohmayr

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the version of googleapis/googleapis in repositories.bzl

2 participants

@ohmayr @parthea