fix(rest): Use strict encoding to lowercase query string bools #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- depend on google-api-core >= 2.10.0 for REST transport - use `strict` to force query string booleans to be JSON encoded in lower case
4290a9c to
aec3ccc
Compare
parthea
approved these changes
Sep 9, 2022
vam-google
reviewed
Sep 12, 2022
| "{{ req_field.field_pb.default_value }}", | ||
| {% else %} | ||
| {{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}, | ||
| str({{ req_field.type.python_type(req_field.field_pb.default_value or 0) }}), |
Contributor
There was a problem hiding this comment.
This does not seem right, and it fails generated unit tests for compute
Contributor
Author
There was a problem hiding this comment.
Now that you mention it, yes, I think you're right. This "else" should be an "elseif" specific to bools. Yikes! That was quite an oversight on my part. Thanks for catching it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictto force query string booleans to be JSON encoded in lower caseFixes #1407