Skip to content

chore: remove unnecessary isset and use null coalescing operator instead #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 2 commits into from
Jul 31, 2025
Merged

chore: remove unnecessary isset and use null coalescing operator instead #726

bshaffer merged 2 commits into from
Jul 31, 2025

Conversation

@bshaffer
Copy link
Collaborator

@bshaffer bshaffer commented Aug 27, 2024 •
edited
Loading

change

$options = isset($this->descriptors[$methodName]['longRunning']) ? $this->descriptors[$methodName]['longRunning'] : [];

to the equivalent but simpler / more readable:

$options = $this->descriptors[$methodName]['longRunning'] ?? [];

BEGIN_COMMIT_OVERRIDE
fix: remove unnecessary isset and use null coalescing operator instead (#726)
END_COMMIT_OVERRIDE

@bshaffer bshaffer requested a review from a team as a code owner August 27, 2024 21:05
@bshaffer bshaffer requested review from a team and Hectorhammett August 27, 2024 21:05
Hectorhammett
Hectorhammett approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@Hectorhammett Hectorhammett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angry approval

@bshaffer bshaffer merged commit da44e49 into main Jul 31, 2025
6 checks passed
@bshaffer bshaffer deleted the simplify-resumeOperation branch July 31, 2025 21:13
@release-please release-please bot mentioned this pull request Sep 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hectorhammett Hectorhammett Hectorhammett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bshaffer @Hectorhammett