This repository was archived by the owner on Jul 13, 2025. It is now read-only.
nodejs: do not throw unhandled rejection#2565
Merged
alexander-fenster merged 1 commit intomasterfrom Feb 13, 2019
Merged
Conversation
lukesneeringer
approved these changes
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2065, googleapis/nodejs-text-to-speech#12, and https://github.com/googleapis/gax-nodejs/issues/121.
I originally expected to fix it in the new TypeScript generator but since the quick fix is easy and many users are affected, let's just do it here. If any stub cannot be initialized for whatever reason (invalid path to credentials file is one possible reason), we'll not fail the constructor, but all the stubs will throw when called. The difference is that those exceptions can be caught by users.