Skip to content

avoid unhandled promise rejection on wrongly initialized stub #494

@jmuk

Description

@jmuk

Reported as googleapis/google-cloud-node#2086:

We should avoid unhandled promise rejections. Right now each method holds a promise for the method of the grpc client instance; this should be avoided.

We should:

  • catch the error on createStub and throw an error
  • or probably we should avoid using promises at all, stub creation and authentication should be delayed and done for the first time a method is called

Metadata

Metadata

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions