-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
Reported as googleapis/google-cloud-node#2086:
We should avoid unhandled promise rejections. Right now each method holds a promise for the method of the grpc client instance; this should be avoided.
We should:
- catch the error on createStub and throw an error
- or probably we should avoid using promises at all, stub creation and authentication should be delayed and done for the first time a method is called
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.