This repository was archived by the owner on Jul 13, 2025. It is now read-only.
Sort the Protofiles to have deterministic order in surface#2453
Merged
andreamlin merged 8 commits intogoogleapis:masterfrom Nov 29, 2018
Merged
Sort the Protofiles to have deterministic order in surface#2453andreamlin merged 8 commits intogoogleapis:masterfrom
andreamlin merged 8 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2453 +/- ##
============================================
+ Coverage 86.54% 86.56% +0.01%
Complexity 5291 5291
============================================
Files 458 458
Lines 21079 21065 -14
Branches 2300 2297 -3
============================================
- Hits 18243 18234 -9
+ Misses 2012 2007 -5
Partials 824 824
Continue to review full report at Codecov.
|
Contributor
Author
|
Waiting for #2443 to get merged so we can test all artman targets. |
Contributor
Author
|
still need to regen some python clients to test this out |
5fd26ca to
32fca96
Compare
Contributor
Author
|
See googleapis/google-cloud-python#6707 for what happens when this PR is used to generate logging. |
Contributor
Author
|
PTAL |
crwilcox
approved these changes
Nov 29, 2018
|
output lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One approach to fix #2319.
Order the enum messages (classes) by name, and then order the enums inside those messages by name.