Codecov Report

Merging #2442 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2442      +/-   ##
============================================
- Coverage     86.57%   86.57%   -0.01%     
+ Complexity     5275     5274       -1     
============================================
  Files           458      458              
  Lines         21003    21002       -1     
  Branches       2279     2279              
============================================
- Hits          18183    18182       -1     
  Misses         2004     2004              
  Partials        816      816

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad593e6...3414d3e. Read the comment docs.

Are able to use this change in a local fork of gapic-generator to generate the desired Bigtable's python client?

@andreamlin

Are able to use this change in a local fork of gapic-generator to generate the desired Bigtable's python client?

I don't have enough knowledge of the toolchain to figure that out: I'm just backing the change out because the bug appeared to occur after the change from #2418 was propagated to the artman image.

@andreamlin Should I close this PR, given your change in #2440?

@tseaver right now i'll generate the python client with and without my change, and see if it the fix fixes this

Verified locally that without this PR (the reverting PR), the StorageType class (from the bigtable synth PR) is incorrectly not generated in the Python client, and with this PR, artman will generate the StorageType class. Therefore, we should check in this PR.

Thanks a lot for opening this reverting PR!