chore(storage): add a test case with colons in header to signedurls#75
Merged
BrennaEpp merged 2 commits intogoogleapis:mainfrom Mar 24, 2023
Merged
chore(storage): add a test case with colons in header to signedurls#75BrennaEpp merged 2 commits intogoogleapis:mainfrom
BrennaEpp merged 2 commits intogoogleapis:mainfrom
Conversation
tritone
approved these changes
Mar 20, 2023
0aee8d1 to
4016aae
Compare
This was referenced Mar 24, 2023
BenWhitehead
added a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Mar 28, 2023
googleapis/conformance-tests@3da70ee fix: remove typo in URL ([#77](googleapis/conformance-tests#77)) googleapis/conformance-tests@c44932a chore(storage): add a test case with colons in header to signedurls ([#75](googleapis/conformance-tests#75)) googleapis/conformance-tests@1aaae63 chore(all): update all ([#72](googleapis/conformance-tests#72)) googleapis/conformance-tests@d84891c chore(all): update go version ([#76](googleapis/conformance-tests#76)) googleapis/conformance-tests@dce68d3 chore: Add TestFile.retry_tests Full diff: googleapis/conformance-tests@ec2e8c3...3da70ee
BenWhitehead
added a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Mar 28, 2023
…c65 (#569) * chore: update clirr config to allow new TestFile.retry_tests property * deps: bump conformance-tests to 3da70eee02ee48f0024e0ffb4711c8a734309c65 googleapis/conformance-tests@3da70ee fix: remove typo in URL ([#77](googleapis/conformance-tests#77)) googleapis/conformance-tests@c44932a chore(storage): add a test case with colons in header to signedurls ([#75](googleapis/conformance-tests#75)) googleapis/conformance-tests@1aaae63 chore(all): update all ([#72](googleapis/conformance-tests#72)) googleapis/conformance-tests@d84891c chore(all): update go version ([#76](googleapis/conformance-tests#76)) googleapis/conformance-tests@dce68d3 chore: Add TestFile.retry_tests Full diff: googleapis/conformance-tests@ec2e8c3...3da70ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on our public docs, values should be able to use any US-ASCII characters, which includes colons.
We recently had to fix the Go client to allow this case.