Add documentation for V4 Signature Post Policy#40
Merged
gcf-merge-on-green[bot] merged 5 commits intomasterfrom Sep 17, 2020
Merged
Add documentation for V4 Signature Post Policy#40gcf-merge-on-green[bot] merged 5 commits intomasterfrom
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
Conversation
tritone
reviewed
Sep 17, 2020
| /* | ||
| Expectations | ||
|
|
||
| E.1: PolicyInput.fields must be preppended to form expectedDecodedPolicy |
Contributor
There was a problem hiding this comment.
sp: prepended
Also, prepended to what? From the example it looks like you're saying that these should come before the other conditions in the policy but it's not 100% clear.
Contributor
Author
There was a problem hiding this comment.
That's correct. I'll update the wording.
| Example: | ||
| PolicyInput.fields has: | ||
| { | ||
| "content-disposition":"attachment; filename=\"~._-%=/é0Aa\"", |
Contributor
There was a problem hiding this comment.
Is this required to be sorted alphabetically by key? If so can that be stated explicitly?
Contributor
Author
There was a problem hiding this comment.
No, the ordering just needs to match the conformance test input.
| "success_action_redirect":"http://www.google.com/" | ||
| } | ||
|
|
||
| Then expectedDecodedPolicy should preppends PolicyInput.fields in |
tritone
approved these changes
Sep 17, 2020
Contributor
tritone
left a comment
There was a problem hiding this comment.
Thanks for adding this Frank!
gcf-merge-on-green bot
pushed a commit
to googleapis/java-conformance-tests
that referenced
this pull request
Sep 17, 2020
…5c8 (#183) googleapis/conformance-tests@d505e92 Add documentation for V4 Signature Post Policy ([#40](googleapis/conformance-tests#40)) googleapis/conformance-tests@424c1dd fix: encoding in conformance tests for v4 signature ([#39](googleapis/conformance-tests#39)) googleapis/conformance-tests@114dff7 feat: add conformance test for content-* fields ([#37](googleapis/conformance-tests#37)) Full diff: googleapis/conformance-tests@0bb8520...d505e92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.