Codecov Report

Merging #68 into master will increase coverage by 0.19%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     60.19%   60.38%   +0.19%     
- Complexity      138      143       +5     
============================================
  Files            14       14              
  Lines           603      616      +13     
  Branches         92       94       +2     
============================================
+ Hits            363      372       +9     
- Misses          217      219       +2     
- Partials         23       25       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bd3cf...8d75255. Read the comment docs.

Thanks for filing this PR!

Does this PR address anything else other than googleapis/google-cloud-java#3604?

Regarding googleapis/google-cloud-java#3604, can you write a test that parses https://www.googleapis.com/compute/v1/projects/project-123/zones/europe-west3-c? I'm not sure if this code would be able to reconcile the compute/v1 substring between the PathTemplate string and the hostname.

(With regard to that issue, our plan is to strip off the https://www.googleapis.com/compute/v1/projects string, defined in the baseUrl of the compute.v1.json API definition file from which the Java Compute client is generated, from the returned path, so that we are left with a parseable project-123/zones/europe-west3-c substring that matches a path template {project}/zones/{zone}/, also defined in the compute.v1.json doc.)

@andreamlin Thanks for review. Added test case for googleapis/google-cloud-java#3604. This PR was suppose to fix googleapis/google-cloud-java#3604 as well as in general to support the url with protocol and hostname. This is non breaking change would also work with your other solution.

@andreamlin can you please review?