This repository was archived by the owner on Sep 27, 2023. It is now read-only.
upgrade some deps #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The Java 7 builds appear to be failing for a different reason - I filed https://github.com/googleapis/api-common-java/issues/58 to get them fixed; we should probably do that before submitting this. |
Contributor
Author
|
Makes sense |
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
============================================
+ Coverage 61.01% 61.17% +0.16%
Complexity 145 145
============================================
Files 14 14
Lines 613 613
Branches 91 92 +1
============================================
+ Hits 374 375 +1
Misses 215 215
+ Partials 24 23 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to upgrade guava too but that ran into issues with errorprone annotations