Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Added transform and transformAsync overrides that accept an Executor #38

Merged
garrettjonesgoogle merged 2 commits into from
Jan 17, 2018
Merged

Added transform and transformAsync overrides that accept an Executor #38

garrettjonesgoogle merged 2 commits into from
Jan 17, 2018

Conversation

@hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Dec 8, 2017

These methods are useful when working with immediate futures and other completed futures.

I also wanted to add some tests, but cannot get past the lint errors. Every time I make the slightest change to ApiFuturesTest.java, I get:

The following files are not formatted properly:

/Users/hkj/Projects/firebase-admin-java/api-common-java/src/test/java/com/google/api/core/ApiFuturesTest.java
:verifyGoogleJavaFormat FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':verifyGoogleJavaFormat'.
> Problems: formatting style violations

Not helpful :(

@codecov-io
Copy link

codecov-io commented Dec 8, 2017 •
edited
Loading

Codecov Report

Merging #38 into master will increase coverage by 0.6%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #38     +/-   ##
===========================================
+ Coverage     59.23%   59.83%   +0.6%     
- Complexity      138      140      +2     
===========================================
  Files            15       15             
  Lines           601      610      +9     
  Branches         91       91             
===========================================
+ Hits            356      365      +9     
  Misses          223      223             
  Partials         22       22
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/google/api/core/ApiFutures.java 93.87% <100%> (+1.37%) 13 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1abec...31d9283. Read the comment docs.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jan 17, 2018

@hiranya911 add the googleJavaFormat task whenever you build to automatically fix formatting every time, for example:

./gradlew googleJavaFormat build

I look forward to having tests added.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jan 17, 2018

Oh wait, you already got the tests added.

@garrettjonesgoogle garrettjonesgoogle merged commit 6e35cbf into googleapis:master Jan 17, 2018
miraleung pushed a commit that referenced this pull request Jun 4, 2020
@hiranya911 @garrettjonesgoogle
Added transform and transformAsync overrides that accept an Executor (#…
491811f 
…38)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiranya911 @codecov-io @garrettjonesgoogle