This repository was archived by the owner on Sep 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Fixing version - making SNAPSHOT #32
Merged
garrettjonesgoogle
merged 5 commits into
googleapis:master
from
garrettjonesgoogle:master
Nov 2, 2017
Merged
Fixing version - making SNAPSHOT #32
garrettjonesgoogle
merged 5 commits into
googleapis:master
from
garrettjonesgoogle:master
Nov 2, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 59.23% 59.23%
Complexity 138 138
=========================================
Files 15 15
Lines 601 601
Branches 91 91
=========================================
Hits 356 356
Misses 223 223
Partials 22 22Continue to review full report at Codecov.
|
vam-google
approved these changes
Nov 2, 2017
Contributor
vam-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
I fixed openjdk7 in Travis - we can apply this same fix to gax-java. PTAL. |
vam-google
approved these changes
Nov 2, 2017
Contributor
vam-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.travis.yml
Outdated
| addons: | ||
| # https://github.com/travis-ci/travis-ci/issues/5227#issuecomment-165131913 | ||
| hosts: | ||
| - fakehostnametoworkaroundtravisbug |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.