fix(ui): Truncate long loading text#9768
Merged
Merged
Conversation
|
Size Change: +20 B (0%) Total Size: 17.4 MB ℹ️ View Unchanged
|
jacob314
approved these changes
Sep 25, 2025
jacob314
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and it looks good
geoffdowns
pushed a commit
to geoffdowns/gemini-cli
that referenced
this pull request
Sep 26, 2025
jkcinouye
pushed a commit
that referenced
this pull request
Sep 29, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 4, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
This pull request updates the
LoadingIndicatorcomponent to truncate long loading phrases instead of wrapping them. This prevents the UI from shifting or expanding when a long loading message is displayed, ensuring a more stable and visually consistent layout.Dive Deeper
Previously, if a long string was provided to the
currentLoadingPhraseprop in theLoadingIndicator, the text would wrap to a new line. This could cause the entire terminal UI to reflow, which is a jarring user experience.This change applies the
wrap="truncate-end"property to theTextcomponent responsible for rendering the primary loading message. Now, any text that exceeds the available width will be cleanly truncated with an ellipsis at the end, maintaining the single-line integrity of the loading indicator.Reviewer Test Plan
Hard to repro.
Testing Matrix
Linked issues / bugs