Unset foreground in default themes by miguelsolorio · Pull Request #9765 · google-gemini/gemini-cli

miguelsolorio · 2025-09-25T17:59:37Z

TLDR

This fixes a long standing issue where users on light terminals can't really see the text.

Dive Deeper

By unsetting the foreground color, it relies on using the terminal foreground color. This only applies to our default dark/light themes, other themes will have custom foreground colors.

Before

After

Reviewer Test Plan

Testing Matrix

	🍏	🪟	🐧
npm run	✅	❓	❓
npx	❓	❓	❓
Docker	❓	❓	❓
Podman	❓	-	-
Seatbelt	❓	-	-

Linked issues / bugs

… to be used

gemini-code-assist · 2025-09-25T17:59:54Z

Summary of Changes

Hello @miguelsolorio, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a long-standing readability issue by modifying the default lightTheme and darkTheme to no longer explicitly set a foreground color, allowing terminal emulators to dictate text color for better contrast. Additionally, it refines the fallback logic in a utility function to handle optional parameters more robustly, ensuring correct behavior when default colors are intentionally unset or provided as falsy values.

Highlights

Default Theme Foreground Colors: The Foreground color property has been unset in both the lightTheme and darkTheme definitions. This change allows the terminal's native foreground color to be used, which significantly improves text visibility for users on light terminals.
Improved Fallback Logic for getStatusColor: The getStatusColor utility function now uses a more precise !== undefined check for options.defaultColor instead of the || operator. This ensures that valid falsy values (like an empty string) for defaultColor are correctly applied, preventing unintended fallbacks to theme.status.error.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively addresses the text visibility issue on light-themed terminals by unsetting the foreground color in the default themes, allowing the terminal's native color to be used. The accompanying change in displayUtils.ts is a crucial bug fix that ensures an empty string color value is handled correctly, preventing it from incorrectly falling back to an error color. I have one suggestion to improve code consistency.

github-actions · 2025-09-25T18:02:55Z

Size Change: -16 B (0%)

Total Size: 17.4 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	17.4 MB	-16 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	830 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

jacob314

jacob314 · 2025-09-25T20:37:36Z

  if (value >= thresholds.yellow) {
    return theme.status.warning;
  }
-  return options.defaultColor || theme.status.error;


did you gemini cli catch this or did you manually debug to fix this? For what it is worth this seems wrong both before and after. Likely we should have a red/error threshold and return theme.status.error in that case
and always return options.defaultColor for this default case.

Gemini originally made the change but then GCA suggested this instead (you can see the resolved thread above). Happy to add your suggestions.

Let me follow up in a subsequent PR to address this

…mini#9765)

Unset foreground in default themes to allow terminal foreground color…

c25a052

… to be used

miguelsolorio requested a review from jacob314 September 25, 2025 17:59

miguelsolorio assigned jacob314 Sep 25, 2025

miguelsolorio requested a review from a team as a code owner September 25, 2025 17:59

Merge branch 'main' into miguelsolorio/default-themes-foreground

016c8c8

gemini-code-assist Bot reviewed Sep 25, 2025

View reviewed changes

Comment thread packages/cli/src/ui/utils/displayUtils.ts Outdated

miguelsolorio and others added 4 commits September 25, 2025 11:19

Merge branch 'main' into miguelsolorio/default-themes-foreground

dbfd771

Simplify to be more consistent with the rest of the codebase

581752b

Merge branch 'main' into miguelsolorio/default-themes-foreground

78eee25

Merge branch 'main' into miguelsolorio/default-themes-foreground

a0075ed

jacob314 approved these changes Sep 25, 2025

View reviewed changes

miguelsolorio added 2 commits September 25, 2025 14:14

Merge branch 'main' into miguelsolorio/default-themes-foreground

f2302f0

Merge branch 'main' into miguelsolorio/default-themes-foreground

d5a16c5

miguelsolorio added this pull request to the merge queue Sep 25, 2025

Merged via the queue into main with commit 18e5113 Sep 25, 2025
17 of 18 checks passed

miguelsolorio deleted the miguelsolorio/default-themes-foreground branch September 25, 2025 22:20

geoffdowns pushed a commit to geoffdowns/gemini-cli that referenced this pull request Sep 26, 2025

Unset foreground in default themes (google-gemini#9765)

58c68ae

dtometzki pushed a commit to dtometzki/gemini-cli that referenced this pull request Sep 26, 2025

Unset foreground in default themes (google-gemini#9765)

0b3c42e

jkcinouye pushed a commit that referenced this pull request Sep 29, 2025

Unset foreground in default themes (#9765)

44cc1d4

thacio added a commit to thacio/auditaria that referenced this pull request Oct 4, 2025

Merge Commit '18e5113': Unset foreground in default themes (google-ge…

ba974c8

…mini#9765)

giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025

Unset foreground in default themes (google-gemini#9765)

9a6699f

cocosheng-g pushed a commit that referenced this pull request May 6, 2026

Unset foreground in default themes (#9765)

5ea38dc

sripasg added the size/xs An extra small PR label Jun 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unset foreground in default themes#9765

Unset foreground in default themes#9765
miguelsolorio merged 8 commits into
mainfrom
miguelsolorio/default-themes-foreground

miguelsolorio commented Sep 25, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Sep 25, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

jacob314 left a comment

Uh oh!

jacob314 Sep 25, 2025

Uh oh!

miguelsolorio Sep 25, 2025

Uh oh!

miguelsolorio Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

miguelsolorio commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

Dive Deeper

Before

After

Reviewer Test Plan

Testing Matrix

Linked issues / bugs

Uh oh!

gemini-code-assist Bot commented Sep 25, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

jacob314 Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

miguelsolorio Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

miguelsolorio Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miguelsolorio commented Sep 25, 2025 •

edited

Loading

github-actions Bot commented Sep 25, 2025 •

edited

Loading