fix(core): reject numeric project IDs in GOOGLE_CLOUD_PROJECT (#24695) by Abhijit-2592 · Pull Request #26532 · google-gemini/gemini-cli

Abhijit-2592 · 2026-05-05T19:28:04Z

Summary

This PR adds validation to reject numeric-only project IDs in the GOOGLE_CLOUD_PROJECT (and GOOGLE_CLOUD_PROJECT_ID) environment variables.

Details

Setting a numeric Project Number instead of a string-based Project ID caused the Gemini API to fail with a generic 400 INVALID_ARGUMENT error. This change introduces an InvalidNumericProjectIdError that is thrown early during setup, providing clear guidance to the user on how to fix their configuration.

Related Issues

Fixes #24695

How to Validate

Set GOOGLE_CLOUD_PROJECT to a numeric value (e.g., export GOOGLE_CLOUD_PROJECT=123456789).
Run any command (e.g., gemini help).
Observe the clear error message instead of an API failure.
Run tests: npm test -w @google/gemini-cli-core -- src/code_assist/setup.test.ts

Pre-Merge Checklist

Setting the `GOOGLE_CLOUD_PROJECT` environment variable to a numeric Project Number instead of a string Project ID caused the Gemini API to fail with a generic `INVALID_ARGUMENT` error. This adds a validation check during setup that throws a clear `InvalidNumericProjectIdError` when a numeric-only project ID is provided, guiding users to use their string-based Project ID.

gemini-code-assist · 2026-05-05T19:28:14Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the developer experience by proactively validating project ID configurations. By preventing the use of numeric project numbers where string-based project IDs are required, it avoids confusing API failures and provides actionable feedback to the user during the setup process.

Highlights

Validation Logic: Introduced a regex-based check to detect and reject numeric-only project IDs in the GOOGLE_CLOUD_PROJECT and GOOGLE_CLOUD_PROJECT_ID environment variables.
Error Handling: Added a new custom error class, InvalidNumericProjectIdError, to provide users with clear guidance when they incorrectly provide a project number instead of a project ID.
Testing: Added a new test case to verify that the system correctly throws the new error when a numeric project ID is detected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-05-05T19:31:14Z

Size Change: +599 B (0%)

Total Size: 34 MB

Filename	Size	Change
`./bundle/chunk-5OV6KWKD.js`	0 B	-49.2 kB (removed)	🏆
`./bundle/chunk-BHTFO55P.js`	0 B	-14.7 MB (removed)	🏆
`./bundle/chunk-GWBZRTU4.js`	0 B	-658 kB (removed)	🏆
`./bundle/chunk-INWZSZM6.js`	0 B	-3.8 kB (removed)	🏆
`./bundle/chunk-NCUVRGNS.js`	0 B	-2.78 MB (removed)	🏆
`./bundle/chunk-OGSVK4K3.js`	0 B	-12.5 kB (removed)	🏆
`./bundle/chunk-PZNUMDYX.js`	0 B	-19.5 kB (removed)	🏆
`./bundle/chunk-XSVETYIJ.js`	0 B	-3.43 kB (removed)	🏆
`./bundle/core-WQLIAMKX.js`	0 B	-48.7 kB (removed)	🏆
`./bundle/devtoolsService-H5VTYGUI.js`	0 B	-28 kB (removed)	🏆
`./bundle/gemini-WMCKGOYV.js`	0 B	-583 kB (removed)	🏆
`./bundle/interactiveCli-RXK2PQZZ.js`	0 B	-1.29 MB (removed)	🏆
`./bundle/liteRtServerManager-N42F6Y2S.js`	0 B	-2.11 kB (removed)	🏆
`./bundle/oauth2-provider-ACULVBSL.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-24IA3FGM.js`	3.43 kB	+3.43 kB (new file)	🆕
`./bundle/chunk-2JWPBMWS.js`	14.7 MB	+14.7 MB (new file)	🆕
`./bundle/chunk-4RNKSSLF.js`	49.2 kB	+49.2 kB (new file)	🆕
`./bundle/chunk-7VUJHYVV.js`	19.5 kB	+19.5 kB (new file)	🆕
`./bundle/chunk-IR2LQI54.js`	2.78 MB	+2.78 MB (new file)	🆕
`./bundle/chunk-UVO6SFDY.js`	3.8 kB	+3.8 kB (new file)	🆕
`./bundle/chunk-XCQLFISN.js`	12.5 kB	+12.5 kB (new file)	🆕
`./bundle/chunk-YF6NNLE3.js`	658 kB	+658 kB (new file)	🆕
`./bundle/core-OB4R3EJM.js`	48.8 kB	+48.8 kB (new file)	🆕
`./bundle/devtoolsService-M5QH7Y7L.js`	28 kB	+28 kB (new file)	🆕
`./bundle/gemini-JUQD7XB4.js`	583 kB	+583 kB (new file)	🆕
`./bundle/interactiveCli-WZVUHY5K.js`	1.29 MB	+1.29 MB (new file)	🆕
`./bundle/liteRtServerManager-3LQ7SY7G.js`	2.11 kB	+2.11 kB (new file)	🆕
`./bundle/oauth2-provider-3P7WX7O4.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/bundled/third_party/index.js`	8 MB	0 B
`./bundle/chunk-34MYV7JD.js`	2.45 kB	0 B
`./bundle/chunk-5AUYMPVF.js`	858 B	0 B
`./bundle/chunk-5PS3AYFU.js`	1.18 kB	0 B
`./bundle/chunk-664ZODQF.js`	124 kB	0 B
`./bundle/chunk-DAHVX5MI.js`	206 kB	0 B
`./bundle/chunk-ECNYAST2.js`	1.97 MB	0 B
`./bundle/chunk-IUUIT4SU.js`	56.5 kB	0 B
`./bundle/chunk-RJTRUG2J.js`	39.8 kB	0 B
`./bundle/cleanup-IE3MMZUT.js`	0 B	-932 B (removed)	🏆
`./bundle/devtools-36NN55EP.js`	696 kB	0 B
`./bundle/dist-T73EYRDX.js`	356 B	0 B
`./bundle/events-XB7DADIJ.js`	418 B	0 B
`./bundle/examples/hooks/scripts/on-start.js`	188 B	0 B
`./bundle/examples/mcp-server/example.js`	1.43 kB	0 B
`./bundle/gemini.js`	5.1 kB	0 B
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB	0 B
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB	0 B
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB	0 B
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB	0 B
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB	0 B
`./bundle/memoryDiscovery-FB7MMKTA.js`	980 B	0 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	222 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	229 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	13.4 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB	0 B
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB	0 B
`./bundle/src-QVCVGIUX.js`	47 kB	0 B
`./bundle/start-JBX6ABZX.js`	0 B	-652 B (removed)	🏆
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB	0 B
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB	0 B
`./bundle/cleanup-7ZZCMHTF.js`	932 B	+932 B (new file)	🆕
`./bundle/start-SJPF4JAU.js`	652 B	+652 B (new file)	🆕

_{compressed-size-action}

gemini-code-assist

Code Review

This pull request introduces a validation check for the Google Cloud Project ID within the setupUser function. It adds a new InvalidNumericProjectIdError class that is triggered when a numeric Project ID is provided instead of the required string-based ID. Additionally, a unit test has been included to verify this new error handling. I have no feedback to provide as there were no review comments.

…CLOUD_PROJECT_ID

…-gemini#24695) (google-gemini#26532)

Abhijit-2592 requested a review from a team as a code owner May 5, 2026 19:28

joshualitt approved these changes May 5, 2026

View reviewed changes

gemini-code-assist Bot reviewed May 5, 2026

View reviewed changes

fix(core): update numeric project ID error message to mention GOOGLE_…

5462616

…CLOUD_PROJECT_ID

Abhijit-2592 enabled auto-merge May 5, 2026 19:35

gemini-cli Bot added the area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality label May 5, 2026

Abhijit-2592 added this pull request to the merge queue May 5, 2026

Merged via the queue into main with commit f29eb9a May 5, 2026
27 checks passed

Abhijit-2592 deleted the abhijit-2592/fix-numeric-project-id branch May 5, 2026 20:05

kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026

fix(core): reject numeric project IDs in GOOGLE_CLOUD_PROJECT (google…

8c1b52b

…-gemini#24695) (google-gemini#26532)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): reject numeric project IDs in GOOGLE_CLOUD_PROJECT (#24695)#26532

fix(core): reject numeric project IDs in GOOGLE_CLOUD_PROJECT (#24695)#26532
Abhijit-2592 merged 2 commits intomainfrom
abhijit-2592/fix-numeric-project-id

Abhijit-2592 commented May 5, 2026

Uh oh!

gemini-code-assist Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Abhijit-2592 commented May 5, 2026

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist Bot commented May 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented May 5, 2026 •

edited

Loading