Skip to content

fix(core): retry on ERR_STREAM_PREMATURE_CLOSE errors#26519

Merged
Adib234 merged 3 commits intomainfrom
fix/issue-25253
May 5, 2026
Merged

fix(core): retry on ERR_STREAM_PREMATURE_CLOSE errors#26519
Adib234 merged 3 commits intomainfrom
fix/issue-25253

Conversation

@cocosheng-g
Copy link
Copy Markdown
Contributor

@cocosheng-g cocosheng-g commented May 5, 2026 •
edited
Loading

Summary

This PR fixes the frequent ERR_STREAM_PREMATURE_CLOSE errors reported in #25253. These errors occur when a response stream is interrupted, which is common during long generations. By adding this error code to the retryable list, the CLI can now automatically recover from these transient network hiccups.

Details

  • Added ERR_STREAM_PREMATURE_CLOSE to RETRYABLE_NETWORK_CODES in packages/core/src/utils/retry.ts.
  • This change enables the existing mid-stream retry logic in GeminiChat to catch and handle this error.
  • Restored .gemini/settings.json which was accidentally deleted in a previous commit.

Related Issues

Fixes #25253

How to Validate

I have added a regression test case to packages/core/src/core/geminiChat_network_retry.test.ts that:

  1. Simulates a mid-stream ERR_STREAM_PREMATURE_CLOSE error.
  2. Verifies that the CLI automatically triggers a retry.
  3. Confirms that the session completes successfully after the retry.

To run the test:

npm test -w @google/gemini-cli-core -- src/core/geminiChat_network_retry.test.ts

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on MacOS

@cocosheng-g cocosheng-g requested a review from a team as a code owner May 5, 2026 17:51
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 5, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the core streaming functionality by explicitly handling 'ERR_STREAM_PREMATURE_CLOSE' as a retryable error. This ensures that transient network issues causing premature stream closures do not result in immediate failure, improving the overall reliability of content generation streams.

Highlights

  • Error Handling Improvement: Added 'ERR_STREAM_PREMATURE_CLOSE' to the list of retryable network error codes to improve resilience against stream interruptions.
  • Regression Testing: Introduced a new test file to verify that the system correctly retries operations when a premature stream close error occurs.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/settings.json
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds 'ERR_STREAM_PREMATURE_CLOSE' to the list of retryable network error codes in the core package. It also introduces a regression test to ensure that streaming content generation successfully retries when this specific error occurs mid-stream. I have no feedback to provide as there were no review comments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026 •
edited
Loading

Size Change: +28 B (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-2FYZLGZO.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-2MLCQYIU.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-6DHHNIXI.js 0 B -2.78 MB (removed) 🏆
./bundle/chunk-7DI4UAL6.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-GEBXPFA6.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-L2OLO656.js 0 B -658 kB (removed) 🏆
./bundle/chunk-NGHAFHYE.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-TMUJBMM7.js 0 B -3.8 kB (removed) 🏆
./bundle/core-7VDBELN5.js 0 B -48.7 kB (removed) 🏆
./bundle/devtoolsService-EVVM3TTM.js 0 B -28 kB (removed) 🏆
./bundle/gemini-73AHUN36.js 0 B -583 kB (removed) 🏆
./bundle/interactiveCli-BJ5ZUZGL.js 0 B -1.29 MB (removed) 🏆
./bundle/liteRtServerManager-WZ5RGPME.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-HSPEWCTQ.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-52ATWNEP.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-5CJD27VL.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-CNE2BJFW.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-D3SZBLFM.js 2.78 MB +2.78 MB (new file) 🆕
./bundle/chunk-JEBXVWXY.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-UDSWVR6Y.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-WH2CN6SJ.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-WWVWJUYU.js 658 kB +658 kB (new file) 🆕
./bundle/core-2OFGPXCG.js 48.7 kB +48.7 kB (new file) 🆕
./bundle/devtoolsService-TDOBYACP.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-CHVKPIJ7.js 583 kB +583 kB (new file) 🆕
./bundle/interactiveCli-RT2JQ7FS.js 1.29 MB +1.29 MB (new file) 🆕
./bundle/liteRtServerManager-HR3TAO4B.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-UPGZW2CL.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-ECNYAST2.js 1.97 MB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-D7NOHH5C.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-FB7MMKTA.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-DDL5MGZA.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-EZT26W2I.js 932 B +932 B (new file) 🆕
./bundle/start-DW6GCAO3.js 652 B +652 B (new file) 🆕

compressed-size-action

@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label May 5, 2026
@Adib234 Adib234 added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit f5c0977 May 5, 2026
27 checks passed
@Adib234 Adib234 deleted the fix/issue-25253 branch May 5, 2026 19:34
kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026
@cocosheng-g @kimjune01
fix(core): retry on ERR_STREAM_PREMATURE_CLOSE errors (google-gemini#…
f89f835 
…26519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adib234 Adib234 Adib234 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Frequent ERR_STREAM_PREMATURE_CLOSE during response streaming and tool execution

2 participants

@cocosheng-g @Adib234