Code Review

This pull request introduces a privacy warning in the VoiceModelDialog and the settings schema, informing users that voice recordings are sent to Google Cloud when using the Gemini Live backend. It also adds a new test suite for the VoiceModelDialog to verify this behavior. A critical issue was identified where a snapshot file for SettingsDialog was deleted, which will cause CI test failures and needs to be addressed.

From /review-frontend:

Code Review for PR #26454 (Frontend Focus)

Summary

This PR successfully introduces a conditional privacy warning in the VoiceModelDialog when the Gemini Live API backend is highlighted. The UI implementation and the React state handling for the highlighted item are logically sound and match the existing component patterns.

However, the new unit tests introduced in VoiceModelDialog.test.tsx are failing the CI pipeline because they interact with Ink components (stdin.write) without wrapping the interactions in act(). Additionally, I investigated the automated comment from gemini-code-assist about a 'deleted snapshot' and confirmed it is a false positive—no snapshot files were deleted, and existing snapshot tests pass successfully.

Findings

Critical

• Test Failures (VoiceModelDialog.test.tsx): The UI component tests simulate user keystrokes using stdin.write but fail to wrap these side-effecting operations in act(). In this repository, vitest treats act() warnings as strict errors. To fix the CI tests, you need to import act from react and wrap the stdin.write calls.

  Example Fix:

  import { act } from 'react';
  
  // ...
  
  await act(async () => {
    stdin.write('\u001b[B'); // Arrow Down
  });
  
  // ...
  
  await act(async () => {
    stdin.write('\r'); // Enter
  });

Improvements

• PR Description Clarification: The PR description mentions 'Updated SettingsDialog.test.tsx snapshots due to the improved setting description.' However, experimental.voice.backend is not actually captured in those snapshots, so no snapshot update was necessary (and none was included in the commit). You might want to remove that line from the PR description to avoid confusion for future maintainers.
• Automated Bot Hallucination: You can safely ignore the comment from gemini-code-assist about the deleted snapshot file. Verification confirms SettingsDialog.test.tsx passes locally without any missing snapshot files.

Conclusion

Request Changes

The frontend feature itself is implemented perfectly, but the missing act() wrappers in the new tests block the build. Once those test interactions are updated to use await act(async () => { ... }), the CI will pass and the PR will be ready to merge.

LGTM