Skip to content

fix(core): Minor fixes for generalist profile.#26357

Merged
joshualitt merged 2 commits intomainfrom
jl/fix-regression
May 5, 2026
Merged

fix(core): Minor fixes for generalist profile.#26357
joshualitt merged 2 commits intomainfrom
jl/fix-regression

Conversation

@joshualitt
Copy link
Copy Markdown
Contributor

@joshualitt joshualitt commented May 2, 2026 •
edited
Loading

@joshualitt joshualitt force-pushed the jl/fix-regression branch 2 times, most recently from 0fc9d76 to aec050b Compare May 2, 2026 01:34
@joshualitt joshualitt marked this pull request as ready for review May 2, 2026 01:36
@joshualitt joshualitt requested a review from a team as a code owner May 2, 2026 01:36
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 2, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements several refinements to the core context management system. The primary goal is to optimize background consolidation processes and improve the quality of synthesized context snapshots, while also adjusting default profile parameters to better balance token usage and performance.

Highlights

  • Context Management Optimization: Introduced a coalescingThresholdTokens configuration to prevent excessive background consolidation churn by only triggering snapshots when a significant number of tokens have aged out.
  • Generalist Profile Adjustments: Updated the generalist profile with higher thresholds for node distillation and truncation to improve context handling efficiency.
  • History Scrubbing: Integrated automatic history scrubbing in GeminiChat when context management is enabled to ensure cleaner data processing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a coalescingThresholdTokens configuration to optimize background context consolidation by ensuring a minimum token deficit before triggering snapshots. It also increases token thresholds for distillation and truncation in the generalist profile and refines the snapshot generator's system prompt. Review feedback identifies a high-severity prompt injection risk in the snapshot generation logic and points out that the new history scrubbing in GeminiChat is redundant and negatively impacts observability.

Comment thread packages/core/src/context/utils/snapshotGenerator.ts
Comment thread packages/core/src/core/geminiChat.ts
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026 •
edited
Loading

Size Change: +539 B (0%)

Total Size: 33.9 MB

Filename Size Change
./bundle/chunk-2NYUELT4.js 0 B -2.72 MB (removed) 🏆
./bundle/chunk-45ACX5FA.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-DIJJRSWM.js 0 B -12.5 kB (removed) 🏆
./bundle/chunk-EDUNVPH3.js 0 B -657 kB (removed) 🏆
./bundle/chunk-KNOM2IUH.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-ODIOCWI6.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-PPD56YFM.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-XNNO7ZMD.js 0 B -49.2 kB (removed) 🏆
./bundle/core-QEQR3OQG.js 0 B -48.4 kB (removed) 🏆
./bundle/devtoolsService-S7H3ZTK6.js 0 B -28 kB (removed) 🏆
./bundle/gemini-EOWUYHUI.js 0 B -582 kB (removed) 🏆
./bundle/interactiveCli-UNDWFVBQ.js 0 B -1.32 MB (removed) 🏆
./bundle/liteRtServerManager-ZAIATVPR.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-NJWPAIUH.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-73HJW4BV.js 657 kB +657 kB (new file) 🆕
./bundle/chunk-BJDTPSDH.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-C2FX3223.js 2.72 MB +2.72 MB (new file) 🆕
./bundle/chunk-D4PHIGPV.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-GZIDXBAK.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-HVH55T33.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-I33TJC55.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-SCKY4A7H.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/core-3BF6J4RK.js 48.4 kB +48.4 kB (new file) 🆕
./bundle/devtoolsService-WFZD3F5K.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-ITLUOTLW.js 582 kB +582 kB (new file) 🆕
./bundle/interactiveCli-YVBTYJJV.js 1.32 MB +1.32 MB (new file) 🆕
./bundle/liteRtServerManager-34K3ZQBD.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-7VWIMO46.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-DD4MWEAB.js 1.97 MB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-VKDR6L4H.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.1 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-HRURE3F3.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-IBU24OCT.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-FYJ3QOST.js 932 B +932 B (new file) 🆕
./bundle/start-MPSIMC75.js 652 B +652 B (new file) 🆕

compressed-size-action

@joshualitt joshualitt force-pushed the jl/fix-regression branch from aec050b to 1055911 Compare May 2, 2026 01:43
This was referenced May 2, 2026
Open
Open
@joshualitt joshualitt added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 0803007 May 5, 2026
28 checks passed
@joshualitt joshualitt deleted the jl/fix-regression branch May 5, 2026 19:46
kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026
@joshualitt @kimjune01
fix(core): Minor fixes for generalist profile. (google-gemini#26357)
4e88213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gundermanc gundermanc gundermanc approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure model history is scrubbed in all cases of internal properties used for bookeeping.

2 participants

@joshualitt @gundermanc