fix(cli): respect .env override for GOOGLE_CLOUD_PROJECT#26288
fix(cli): respect .env override for GOOGLE_CLOUD_PROJECT#26288DavidAPierce merged 3 commits intomainfrom
Conversation
…ll when auth type is vertex-ai Removed the early return in `setUpCloudShellEnvironment` so that the .env override logic is correctly applied.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where environment variable overrides defined in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @DavidAPierce, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -80 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request refactors the setUpCloudShellEnvironment function to ensure that .env file configurations for GOOGLE_CLOUD_PROJECT are correctly applied when using Vertex AI authentication within Cloud Shell. By integrating the Vertex AI project logic into the main environment processing flow, the system now properly prioritizes local environment file settings over default Cloud Shell values. Additionally, a new test case has been added to verify this override behavior. I have no feedback to provide.
Summary
Fixes a bug where
GOOGLE_CLOUD_PROJECToverrides from.envfiles were being ignored in Cloud Shell when thevertex-aiauthentication type was selected.Details
Previously,
setUpCloudShellEnvironmentreturned early ifAuthType.USE_VERTEX_AIwas selected, completely skipping the local.envparsing block. Because the environment variable was populated before returning,loadEnvironment's generic parser would skip it, leaving.envoverrides ignored.This change removes the early return, sets the baseline project fallback appropriately, and executes the
.envparsing logic for all authentication types. This guarantees that explicit.envconfigurations are correctly respected.Related Issues
Follow up for #24494
How to Validate
.envoverride logic:npm run test -- packages/cli/src/config/settings.test.ts -t "should respect .env override for GOOGLE_CLOUD_PROJECT in Cloud Shell when auth type is vertex-ai"GOOGLE_CLOUD_PROJECTin your.envfile, switch your auth type tovertex-ai, and verify that the CLI respects the.envproject over thegcloudactive project.Pre-Merge Checklist