Skip to content

fix(cli): use resolved sandbox state for auto-update check#26285

Merged
Adib234 merged 1 commit intomainfrom
fix/sandbox-update-check
Apr 30, 2026
Merged

fix(cli): use resolved sandbox state for auto-update check#26285
Adib234 merged 1 commit intomainfrom
fix/sandbox-update-check

Conversation

@Adib234
Copy link
Copy Markdown
Contributor

@Adib234 Adib234 commented Apr 30, 2026

Summary

Fixes an issue where Gemini CLI fails to self-update if the sandbox is configured in settings.json, even when the CLI is run with the sandbox disabled via CLI flags (e.g., -s false).

Details

The handleAutoUpdate function was directly checking the raw settings.merged.tools.sandbox and the GEMINI_SANDBOX environment variable. This bypassed the CLI's configuration resolution logic, which is responsible for overriding settings with command-line flags.

This PR:

  • Updates handleAutoUpdate to accept an isSandboxEnabled boolean parameter.
  • Updates interactiveCli.tsx to pass the resolved sandbox state from config.getSandboxEnabled().
  • Updates unit tests to reflect the new signature and adds a regression test case.

Related Issues

Fixes #24000

How to Validate

  1. Run unit tests: npm test -w @google/gemini-cli -- packages/cli/src/utils/handleAutoUpdate.test.ts
  2. Verify type safety: npm run typecheck

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@Adib234 Adib234 requested a review from a team as a code owner April 30, 2026 20:22
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

Size Change: +26 B (0%)

Total Size: 33.9 MB

Filename Size Change
./bundle/chunk-2YAG37N7.js 0 B -656 kB (removed) 🏆
./bundle/chunk-74GSIUYA.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-B4WRUYZZ.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-EPZ54RCA.js 0 B -19.5 kB (removed) 🏆
./bundle/chunk-LCU42UHC.js 0 B -2.72 MB (removed) 🏆
./bundle/chunk-OYLICXPA.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-XTDTL2VG.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-YETKNMPG.js 0 B -12.6 kB (removed) 🏆
./bundle/core-QYQFBWRP.js 0 B -48.2 kB (removed) 🏆
./bundle/devtoolsService-SCLA2AHO.js 0 B -28 kB (removed) 🏆
./bundle/gemini-3KCABWKS.js 0 B -580 kB (removed) 🏆
./bundle/interactiveCli-XDVGQ5HC.js 0 B -1.32 MB (removed) 🏆
./bundle/liteRtServerManager-Q7BKZ2VR.js 0 B -2.11 kB (removed) 🏆
./bundle/oauth2-provider-U6IVUAKC.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-BT2KZTS6.js 12.5 kB +12.5 kB (new file) 🆕
./bundle/chunk-EG2Q4JIW.js 2.72 MB +2.72 MB (new file) 🆕
./bundle/chunk-I65YHN4L.js 19.5 kB +19.5 kB (new file) 🆕
./bundle/chunk-LTGNYINI.js 656 kB +656 kB (new file) 🆕
./bundle/chunk-OKFZBFLR.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-PXB353OP.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/chunk-WVORR377.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-YH4Z53VI.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/core-EOAQXBDV.js 48.2 kB +48.2 kB (new file) 🆕
./bundle/devtoolsService-HHCCYFQ5.js 28 kB +28 kB (new file) 🆕
./bundle/gemini-3OTWKFAU.js 580 kB +580 kB (new file) 🆕
./bundle/interactiveCli-KR5TUTJW.js 1.32 MB +1.32 MB (new file) 🆕
./bundle/liteRtServerManager-PIJGMEMD.js 2.11 kB +2.11 kB (new file) 🆕
./bundle/oauth2-provider-46XCHGPI.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-OQX7GVID.js 1.97 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-PWRGWHJA.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 5.14 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-QEUOLE5X.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-BW27KJ5N.js 0 B -652 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-MYWZYMKL.js 932 B +932 B (new file) 🆕
./bundle/start-MZTR4NFD.js 652 B +652 B (new file) 🆕

compressed-size-action

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Apr 30, 2026

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 30, 2026
devr0306
devr0306 approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devr0306 devr0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adib234 Adib234 added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit f497240 Apr 30, 2026
30 checks passed
@Adib234 Adib234 deleted the fix/sandbox-update-check branch April 30, 2026 22:19
TirthNaik-99 pushed a commit to TirthNaik-99/gemini-cli that referenced this pull request May 4, 2026
@Adib234
fix(cli): use resolved sandbox state for auto-update check (google-ge…
570b810 
…mini#26285)
kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026
@Adib234 @kimjune01
fix(cli): use resolved sandbox state for auto-update check (google-ge…
b8c8f0b 
…mini#26285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devr0306 devr0306 devr0306 approved these changes

Assignees

No one assigned

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gemini-cli will not udate if tool.sandbox is present in settings.json regardless of current sandboxing

2 participants

@Adib234 @devr0306