Conversation
|
Hi @ruomengz, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables the Gemini CLI to function correctly as a single-file executable by preventing unnecessary process relaunching. Additionally, it streamlines the development and testing workflow by providing mechanisms to build unsigned binaries on demand. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for binary builds by incorporating checks for the IS_BINARY environment variable to control process relaunching and memory argument configuration. Additionally, it adds a mechanism to skip file signing during the build process via the SKIP_SIGNING environment variable. The review feedback suggests refining the IS_BINARY checks to explicitly compare against the string 'true' for consistency and to prevent logical errors when the variable is set to 'false'.
|
Size Change: +100 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
|
Addresses feedback regarding |
- Add GitHub Actions workflow to build unsigned Mac binaries on demand - Add `SKIP_SIGNING` flag to `build_binary.js` to bypass code signing - Skip daemon relaunch in CLI when `IS_BINARY` is set
Summary
This PR introduces support for running the Gemini CLI as a single-file executable (SEA) by skipping the daemon relaunch process when the
IS_BINARYenvironment variable is set. It also adds a new GitHub Actions workflow to build unsigned Mac binaries on demand.Details
process.env['IS_BINARY']in the CLI entry point and React component to skip the lightweight parent process relaunch. This is necessary because SEA environments often have different node argument requirements and the relaunch mechanism can conflict with the bundled nature of the binary..github/workflows/build-unsigned-mac-binaries.ymlto allow manual triggering of Mac binary builds (x64 and arm64) without requiring code signing. This is useful for rapid testing and distribution to internal/trusted testers.scripts/build_binary.jsto respect aSKIP_SIGNINGenvironment variable, allowing the build process to complete even when signing certificates are not available.Related Issues
Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/1638
How to Validate
Local SEA Build:
Verify the binary runs without relaunching.
GitHub Action:
Manually trigger the "Build Unsigned Mac Binaries" workflow on this branch and verify that the artifacts are generated and downloadable.
Pre-Merge Checklist