fix(ui): made shell tool header wrap on Ctrl+O#26229
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the user interface for shell tools by enabling text wrapping for tool headers. Previously, these headers were truncated, which could hide important information. The changes introduce a new expansion state that can be toggled, allowing users to view full header content when needed, while maintaining a clean, truncated view by default. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces header expansion functionality for tool messages in the CLI. It updates ShellToolMessage, ToolMessage, and the shared ToolInfo component to support an isExpanded state, which is determined by the ToolActionsContext or the absence of a terminal height limit. When expanded, tool descriptions wrap to multiple lines instead of being truncated to a single line. Corresponding unit tests have been added to verify the truncation and expansion logic. I have no feedback to provide.
|
Size Change: +645 B (0%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
Summary
Made shell tool header wrap on Ctrl+O instead of truncate.
Details
Related Issues
Fixes #23800
How to Validate
Ask Gemini to run
npm test -w @google/gemini-cli -- src/ui/components/InputPrompt.test.tsxon a terminal that is not wide. As the shell command is running, click Ctrl+O to expand the content. The command at the top should also wrap instead of truncating.Pre-Merge Checklist