Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the CLI's keyboard shortcut handling to improve the user experience on WSL/Linux environments while maintaining standard behavior for native Windows and macOS users. By implementing smarter input consumption and platform-aware key mapping, it resolves conflicts with OS-level shortcuts and ensures consistent, expected behavior for text manipulation commands.

Highlights

• Platform-Specific Keybindings: Refined Undo/Redo shortcuts to prioritize platform-appropriate keys, specifically promoting 'Alt+Z' and 'Alt+Shift+Z' for Linux/WSL to avoid conflicts with Windows 11 OS-level shortcuts.
• Smart Bubbling: Updated the text buffer input handler to only consume 'Ctrl+Z' when there is content to undo, preserving terminal suspension functionality when the buffer is empty.
• Documentation and Testing: Updated documentation to reflect new shortcut mappings and added comprehensive unit tests to verify platform-specific keybinding logic and buffer behavior.

Size Change: +638 B (0%)

Total Size: 33.9 MB

_{compressed-size-action}

from /review-frontend

Thanks for the PR! The overall approach for smart bubbling is a great idea to solve the WSL collision, and the tests properly wrap synchronous React state updates in act().

However, there is a critical bug where the implementation contradicts the PR description:

1. Missing Ctrl+Z Binding on Linux/WSL: The PR description states: "This allows WSL users to use Ctrl+Z for undoing text (natural behavior) while still being able to use it for terminal suspension when the buffer is empty."
   However, in packages/cli/src/ui/key/keyBindings.ts, the getPlatformUndoBindings function for Linux (the fallback return) is [new KeyBinding('alt+z'), new KeyBinding('cmd+z')]. It explicitly omits Ctrl+Z.

   Because Ctrl+Z is not bound to Command.UNDO on Linux, keyMatchers[Command.UNDO](key) will return false for Ctrl+Z. Thus, the smart bubbling logic in useTextBuffer will never evaluate Ctrl+Z on Linux/WSL, and it will always suspend the terminal, even if there is text to undo.

2. Test Masks the Issue: In packages/cli/src/ui/components/shared/text-buffer.test.ts, the new test should only handle Undo if there is something to undo defines the undoKey for Linux as Alt+Z (alt: true, ctrl: false) rather than Ctrl+Z. This causes the test to pass without actually verifying the intended Ctrl+Z behavior for WSL users.

Recommended Fix:
Add new KeyBinding('ctrl+z') to the fallback return in getPlatformUndoBindings (and similarly for Redo with Ctrl+Y if intended). Additionally, update the test to specifically verify the bubbling behavior using Ctrl+Z on Linux.