test(core): add regression test for issue for ToolConfirmationResponse by Adib234 · Pull Request #26194 · google-gemini/gemini-cli

Adib234 · 2026-04-29T13:15:59Z

Summary

Adds a regression test to ensure that the payload from a ToolConfirmationResponse is correctly passed to the onConfirm callback.

Details

Issue #22120 reported that CoreToolScheduler.handleConfirmationResponse was dropping the payload parameter. This bug was fixed during the migration to the new event-driven scheduler (specifically in packages/core/src/scheduler/confirmation.ts), where the payload is correctly retrieved from the response message and passed to the callback.

This PR adds a dedicated unit test in packages/core/src/scheduler/confirmation.test.ts to verify this behavior and prevent regressions.

Related Issues

Fixes #22120

How to Validate

Run the unit tests for the core package:

npm test -w @google/gemini-cli-core -- src/scheduler/confirmation.test.ts

The new test case "should pass payload to onConfirm callback (Regression for #22120)" should pass.

Pre-Merge Checklist

gemini-code-assist · 2026-04-29T13:16:08Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a regression test to ensure the stability of the ToolConfirmationResponse handling logic. By validating that the payload parameter is correctly propagated to the onConfirm callback, this change prevents future regressions related to issue #22120.

Highlights

Regression Testing: Added a new unit test case to verify that the payload is correctly passed to the onConfirm callback in ToolConfirmationResponse.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a regression test in packages/core/src/scheduler/confirmation.test.ts for issue #22120. The test ensures that the payload from a tool confirmation response is correctly passed to the onConfirm callback. I have no feedback to provide.

github-actions · 2026-04-29T13:19:23Z

Size Change: -4 B (0%)

Total Size: 33.9 MB

Filename	Size	Change
`./bundle/chunk-3ACTODP3.js`	0 B	-12.6 kB (removed)	🏆
`./bundle/chunk-5RG7GFHI.js`	0 B	-19.5 kB (removed)	🏆
`./bundle/chunk-DHSNVVV7.js`	0 B	-3.43 kB (removed)	🏆
`./bundle/chunk-F5EIH5LQ.js`	0 B	-2.72 MB (removed)	🏆
`./bundle/chunk-HSLA6AYO.js`	0 B	-14.7 MB (removed)	🏆
`./bundle/chunk-ONVFWB3P.js`	0 B	-49.2 kB (removed)	🏆
`./bundle/chunk-ULM6U4EB.js`	0 B	-655 kB (removed)	🏆
`./bundle/chunk-UYJFRGGB.js`	0 B	-3.8 kB (removed)	🏆
`./bundle/core-R2OGNBK3.js`	0 B	-48.2 kB (removed)	🏆
`./bundle/devtoolsService-EBFOE2NO.js`	0 B	-28 kB (removed)	🏆
`./bundle/gemini-AURHXUAT.js`	0 B	-576 kB (removed)	🏆
`./bundle/interactiveCli-Z64YQ4D5.js`	0 B	-1.31 MB (removed)	🏆
`./bundle/liteRtServerManager-2KWC6324.js`	0 B	-2.11 kB (removed)	🏆
`./bundle/oauth2-provider-2EYCVHY5.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-2BRZ6X3T.js`	3.43 kB	+3.43 kB (new file)	🆕
`./bundle/chunk-7AOA24GO.js`	12.6 kB	+12.6 kB (new file)	🆕
`./bundle/chunk-ATNYGOOQ.js`	3.8 kB	+3.8 kB (new file)	🆕
`./bundle/chunk-DHDTGDIW.js`	655 kB	+655 kB (new file)	🆕
`./bundle/chunk-GPGP4IH5.js`	14.7 MB	+14.7 MB (new file)	🆕
`./bundle/chunk-J7DOGJMD.js`	49.2 kB	+49.2 kB (new file)	🆕
`./bundle/chunk-LQV6E3BH.js`	19.5 kB	+19.5 kB (new file)	🆕
`./bundle/chunk-WHMH6NEK.js`	2.72 MB	+2.72 MB (new file)	🆕
`./bundle/core-NOBTUWL2.js`	48.2 kB	+48.2 kB (new file)	🆕
`./bundle/devtoolsService-OY6M4QCB.js`	28 kB	+28 kB (new file)	🆕
`./bundle/gemini-TFNHFMYS.js`	576 kB	+576 kB (new file)	🆕
`./bundle/interactiveCli-W3ZKVSKA.js`	1.31 MB	+1.31 MB (new file)	🆕
`./bundle/liteRtServerManager-V4FXBQDP.js`	2.11 kB	+2.11 kB (new file)	🆕
`./bundle/oauth2-provider-YQ7BZQCV.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/bundled/third_party/index.js`	8 MB	0 B
`./bundle/chunk-34MYV7JD.js`	2.45 kB	0 B
`./bundle/chunk-5AUYMPVF.js`	858 B	0 B
`./bundle/chunk-5PS3AYFU.js`	1.18 kB	0 B
`./bundle/chunk-664ZODQF.js`	124 kB	0 B
`./bundle/chunk-DAHVX5MI.js`	206 kB	0 B
`./bundle/chunk-IUUIT4SU.js`	56.5 kB	0 B
`./bundle/chunk-RJTRUG2J.js`	39.8 kB	0 B
`./bundle/chunk-XRLFHCHC.js`	1.97 MB	0 B
`./bundle/cleanup-JAABEUYL.js`	0 B	-932 B (removed)	🏆
`./bundle/devtools-36NN55EP.js`	696 kB	0 B
`./bundle/dist-T73EYRDX.js`	356 B	0 B
`./bundle/events-XB7DADIJ.js`	418 B	0 B
`./bundle/examples/hooks/scripts/on-start.js`	188 B	0 B
`./bundle/examples/mcp-server/example.js`	1.43 kB	0 B
`./bundle/gemini.js`	5.1 kB	0 B
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB	0 B
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB	0 B
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB	0 B
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB	0 B
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB	0 B
`./bundle/memoryDiscovery-FN3IAPBT.js`	980 B	0 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	222 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	229 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	13.4 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB	0 B
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB	0 B
`./bundle/src-QVCVGIUX.js`	47 kB	0 B
`./bundle/start-LUDF7PCT.js`	0 B	-652 B (removed)	🏆
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB	0 B
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB	0 B
`./bundle/cleanup-MRTFPKEP.js`	932 B	+932 B (new file)	🆕
`./bundle/start-Z672IC3N.js`	652 B	+652 B (new file)	🆕

_{compressed-size-action}

google-gemini#26194)

test(core): add regression test for issue #22120

ec0ca55

Adib234 requested a review from a team as a code owner April 29, 2026 13:16

Adib234 changed the title ~~test(core): add regression test for issue #22120~~ test(core): add regression test for issue for ToolConfirmationResponse Apr 29, 2026

gemini-code-assist Bot reviewed Apr 29, 2026

View reviewed changes

gemini-cli Bot added the area/non-interactive Issues related to GitHub Actions, SDK, 3P Integrations, Shell Scripting, Command line automation label Apr 29, 2026

cocosheng-g approved these changes Apr 29, 2026

View reviewed changes

Comment thread packages/core/src/scheduler/confirmation.test.ts Outdated

remove issue number

99fb45d

Adib234 enabled auto-merge April 29, 2026 16:03

Adib234 added this pull request to the merge queue Apr 29, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 29, 2026

Adib234 added this pull request to the merge queue Apr 29, 2026

Merged via the queue into main with commit 3bc56d0 Apr 29, 2026
27 checks passed

Adib234 deleted the adibakm/drop-paylod branch April 29, 2026 18:05

TirthNaik-99 pushed a commit to TirthNaik-99/gemini-cli that referenced this pull request May 4, 2026

test(core): add regression test for issue for ToolConfirmationResponse (

5731f6e

google-gemini#26194)

kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026

test(core): add regression test for issue for ToolConfirmationResponse (

be91aa3

google-gemini#26194)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(core): add regression test for issue for ToolConfirmationResponse#26194

test(core): add regression test for issue for ToolConfirmationResponse#26194
Adib234 merged 2 commits intomainfrom
adibakm/drop-paylod

Adib234 commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot commented Apr 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Adib234 commented Apr 29, 2026

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist Bot commented Apr 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 29, 2026 •

edited

Loading