fix(ui): fix issue with box edges by gundermanc · Pull Request #26148 · google-gemini/gemini-cli

gundermanc · 2026-04-28T23:31:24Z

Summary

Fixes an issue with box edges in ToolGroupMessage where a tool appearing immediately after an update_topic tool would be missing its top border.

Details

Added prevIsTopic check to ensure the top border is drawn when the previous tool group was a topic tool, correctly separating the new tool group from the topic message. Included a new snapshot test renders update_topic in the middle of other tools to prevent regressions.

Related Issues

None

How to Validate

Run the test suite: npm test -w @google/gemini-cli -- src/ui/components/messages/ToolGroupMessage.test.tsx
Ensure the new snapshot tests pass and demonstrate correct border rendering.

Pre-Merge Checklist

github-actions · 2026-04-28T23:34:34Z

Size Change: +224 B (0%)

Total Size: 33.9 MB

Filename	Size	Change
`./bundle/chunk-4UJU45TR.js`	0 B	-19.5 kB (removed)	🏆
`./bundle/chunk-AT44T6KS.js`	0 B	-49.2 kB (removed)	🏆
`./bundle/chunk-BPJZ7W2I.js`	0 B	-655 kB (removed)	🏆
`./bundle/chunk-EAU4D2S2.js`	0 B	-12.6 kB (removed)	🏆
`./bundle/chunk-EPBKX5P6.js`	0 B	-14.7 MB (removed)	🏆
`./bundle/chunk-MWFRG2YP.js`	0 B	-3.8 kB (removed)	🏆
`./bundle/chunk-OIHPO2K7.js`	0 B	-3.43 kB (removed)	🏆
`./bundle/chunk-SOUZ5IAO.js`	0 B	-2.72 MB (removed)	🏆
`./bundle/core-GZI5SCTX.js`	0 B	-48.2 kB (removed)	🏆
`./bundle/devtoolsService-6CALMC3Q.js`	0 B	-28 kB (removed)	🏆
`./bundle/gemini-4QJGBG2W.js`	0 B	-575 kB (removed)	🏆
`./bundle/interactiveCli-G7C3RIG4.js`	0 B	-1.31 MB (removed)	🏆
`./bundle/liteRtServerManager-WFJLJ3S3.js`	0 B	-2.11 kB (removed)	🏆
`./bundle/oauth2-provider-S2OE2IAS.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-3LCLVCEL.js`	2.72 MB	+2.72 MB (new file)	🆕
`./bundle/chunk-4ND5XFCB.js`	14.7 MB	+14.7 MB (new file)	🆕
`./bundle/chunk-7AIBRE3C.js`	3.43 kB	+3.43 kB (new file)	🆕
`./bundle/chunk-BTONQKNJ.js`	3.8 kB	+3.8 kB (new file)	🆕
`./bundle/chunk-FTZBD4FT.js`	12.6 kB	+12.6 kB (new file)	🆕
`./bundle/chunk-QDH7MKA7.js`	49.2 kB	+49.2 kB (new file)	🆕
`./bundle/chunk-QY7WRLJP.js`	655 kB	+655 kB (new file)	🆕
`./bundle/chunk-VTF745VX.js`	19.5 kB	+19.5 kB (new file)	🆕
`./bundle/core-NIR6BQFX.js`	48.2 kB	+48.2 kB (new file)	🆕
`./bundle/devtoolsService-RX2CTWL6.js`	28 kB	+28 kB (new file)	🆕
`./bundle/gemini-6AHOLLTF.js`	575 kB	+575 kB (new file)	🆕
`./bundle/interactiveCli-F7EUHHR6.js`	1.31 MB	+1.31 MB (new file)	🆕
`./bundle/liteRtServerManager-WWC3JB3G.js`	2.11 kB	+2.11 kB (new file)	🆕
`./bundle/oauth2-provider-TDCZ4JHY.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/bundled/third_party/index.js`	8 MB	0 B
`./bundle/chunk-34MYV7JD.js`	2.45 kB	0 B
`./bundle/chunk-5AUYMPVF.js`	858 B	0 B
`./bundle/chunk-5PS3AYFU.js`	1.18 kB	0 B
`./bundle/chunk-664ZODQF.js`	124 kB	0 B
`./bundle/chunk-DAHVX5MI.js`	206 kB	0 B
`./bundle/chunk-IUUIT4SU.js`	56.5 kB	0 B
`./bundle/chunk-RJTRUG2J.js`	39.8 kB	0 B
`./bundle/chunk-XRLFHCHC.js`	1.97 MB	0 B
`./bundle/cleanup-WGWYJAFV.js`	0 B	-932 B (removed)	🏆
`./bundle/devtools-36NN55EP.js`	696 kB	0 B
`./bundle/dist-T73EYRDX.js`	356 B	0 B
`./bundle/events-XB7DADIJ.js`	418 B	0 B
`./bundle/examples/hooks/scripts/on-start.js`	188 B	0 B
`./bundle/examples/mcp-server/example.js`	1.43 kB	0 B
`./bundle/gemini.js`	5.1 kB	0 B
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB	0 B
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB	0 B
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB	0 B
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB	0 B
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB	0 B
`./bundle/memoryDiscovery-FN3IAPBT.js`	980 B	0 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	222 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	229 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	13.4 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB	0 B
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB	0 B
`./bundle/src-QVCVGIUX.js`	47 kB	0 B
`./bundle/start-763RWBA5.js`	0 B	-652 B (removed)	🏆
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB	0 B
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB	0 B
`./bundle/cleanup-5AVX5UKH.js`	932 B	+932 B (new file)	🆕
`./bundle/start-UNUF6LL3.js`	652 B	+652 B (new file)	🆕

_{compressed-size-action}

gemini-code-assist · 2026-04-30T15:08:21Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug in the ToolGroupMessage component where the top border of a tool group was missing if it immediately followed an update_topic tool. By identifying the previous tool as a topic tool, the component now correctly applies the necessary border styling to maintain visual separation.

Highlights

UI Border Fix: Updated ToolGroupMessage to correctly render top borders when a tool follows an update_topic tool.
Regression Testing: Added a new snapshot test to ensure consistent border rendering when update_topic tools appear between other tool groups.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the ToolGroupMessage component to correctly handle the rendering of topic tools when they appear between other tool calls. It introduces logic to identify previous topic tools and adjusts the isFirstProp property to ensure proper visual separation. A new test case and corresponding snapshot have been added to verify this behavior. I have no feedback to provide.

gundermanc · 2026-04-30T16:36:47Z

@gemini-cli please critique this PR:

Does it correctly identify and fix the case that leads to the split box or incomplete outer edge?
Does it have a unit test that sufficiently covers the cases of this bug?
Are there other related bugs we should add test coverage or fixes for at the same time?

gemini-cli · 2026-04-30T16:41:35Z

I've investigated PR #26148 and confirmed that it correctly identifies and fixes the root cause of the split box edges.

Findings

Root Cause Confirmation: The issue occurs because topic tools close the preceding box segment but do not trigger a "reopen" for the following tool. Adding the prevIsTopic check to isFirstProp correctly signals the next tool to start a new boxed segment.
Completeness: To ensure visual stability and correct scrolling, the prevIsTopic logic must be applied to both the staticHeight loop (approx. line 228) and the render loop (approx. line 285).
Test Coverage: The added snapshot test for a topic in the middle of other tools is sufficient and covers the reported regression.

Recommendations

Verify that the staticHeight calculation was updated alongside the render logic.
The isFirst (all-previous-were-topics) loop is technically redundant for index > 0 once prevIsTopic is added, but keeping it for clarity or refactoring it into a simpler isFirstProp check would be an improvement.

Overall, the PR is technically sound and addresses the reported bug effectively.

Abhijit-2592

LGTM

Fix issue with box edges.

9482f81

gundermanc changed the title ~~Fix issue with box edges.~~ fix(ui): fix issue with box edges Apr 28, 2026

github-actions Bot mentioned this pull request Apr 29, 2026

📊 AI CLI 工具社区动态日报 2026-04-29 gsscsd/big_model_radar#261

Open

gundermanc marked this pull request as ready for review April 30, 2026 15:00

gundermanc requested a review from a team as a code owner April 30, 2026 15:00

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Apr 30, 2026

google-gemini deleted a comment from gemini-cli Bot Apr 30, 2026

Abhijit-2592 approved these changes May 1, 2026

View reviewed changes

gundermanc added this pull request to the merge queue May 1, 2026

Merged via the queue into main with commit 8943640 May 1, 2026
31 checks passed

gundermanc deleted the gundermanc/topics-ux branch May 1, 2026 17:03

TirthNaik-99 pushed a commit to TirthNaik-99/gemini-cli that referenced this pull request May 4, 2026

fix(ui): fix issue with box edges (google-gemini#26148)

8bf90cc

kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026

fix(ui): fix issue with box edges (google-gemini#26148)

917d4a8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): fix issue with box edges#26148

fix(ui): fix issue with box edges#26148
gundermanc merged 1 commit intomainfrom
gundermanc/topics-ux

gundermanc commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gundermanc commented Apr 30, 2026

Uh oh!

gemini-cli Bot commented Apr 30, 2026

Uh oh!

Abhijit-2592 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gundermanc commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gundermanc commented Apr 30, 2026

Uh oh!

gemini-cli Bot commented Apr 30, 2026

Findings

Recommendations

Uh oh!

Abhijit-2592 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gundermanc commented Apr 28, 2026 •

edited

Loading