fix(cli): allow output redirection for cli commands#25894
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where CLI subcommand output was being suppressed when redirected or piped. By adjusting how the console is patched during command execution and ensuring proper line termination, the CLI now correctly handles standard output streams in non-interactive environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @spencer426, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -88 B (0%) Total Size: 33.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request modifies the CLI's output handling by updating the ConsolePatcher configuration to account for command execution and appending newlines to CoreEvent.ConsoleLog outputs. Feedback indicates that the newline addition should also be applied to CoreEvent.UserFeedback for consistency, and that all console output should be redirected to stderr to match the patcher's intended behavior and prevent mangled output.
…s to stderr and appending newlines
Summary
This PR fixes a bug where CLI subcommands (like
gemini extensions list) had their output suppressed when piped or redirected. This was caused byConsolePatcherincorrectly inferring headless mode fromargvduring subcommands and suppressingconsole.log.Details
ConsolePatcherinitialization ingemini.tsxto respectargv.isCommand.interactive: trueandstderr: falsewhen a subcommand is being executed, so its output goes to standard output without being suppressed.nonInteractiveCli'scoreEvents.on(CoreEvent.ConsoleLog)listener so that piped tools likewc -lcount lines accurately.Related Issues
Fixes google-gemini/maintainers-gemini-cli#1633
How to Validate
node packages/cli/dist/index.js extensions list | wc -l. It should output a non-zero count if extensions are listed or1for the "No extensions installed" message.node packages/cli/dist/index.js extensions list > /tmp/out.txtand verify the file is not empty.Pre-Merge Checklist