fix(ui): corrected background color check in user message components by devr0306 · Pull Request #25880 · google-gemini/gemini-cli

devr0306 · 2026-04-23T19:38:39Z

Summary

Fixed check for background color in user message components, correctly adding padding around them in the process.

Details

Fixed

packages/cli/src/ui/components/messages/HintMessage.tsx
packages/cli/src/ui/components/messages/UserMessage.tsx
packages/cli/src/ui/components/messages/UserShellMessage.tsx

Related Issues

Fixes #25879

How to Validate

Start the CLI after typing export NO_COLOR=true in the terminal. After asking multiple commands, there should be space around the user messages in the history. Typing a shell command like ! ls should also have padding.

Screenshot:

Pre-Merge Checklist

gemini-code-assist · 2026-04-23T19:41:37Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a UI rendering inconsistency in the CLI's message components. It refines the conditional logic for applying background colors, ensuring that padding is correctly rendered, especially when the NO_COLOR environment variable is active. This improves the visual presentation and accessibility of user messages in various terminal configurations.

Highlights

Refined background color application logic: The logic for useBackgroundColor in HintMessage, UserMessage, and UserShellMessage components was updated to ensure a background color is only applied if the configuration explicitly enables it and a theme background message color is defined. This prevents unintended background rendering.
Improved padding in NO_COLOR environments: This change ensures that when the NO_COLOR environment variable is set, and background colors are disabled, user message components correctly utilize margins for spacing instead of attempting to render background blocks, maintaining proper visual separation.
Expanded test coverage for NO_COLOR scenarios: Dedicated test files were added for HintMessage and UserShellMessage, and UserMessage tests were updated, to specifically verify correct rendering behavior (using margins, no background blocks) when the NO_COLOR environment variable is active.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-04-23T19:42:01Z

Size Change: +275 B (0%)

Total Size: 33.7 MB

Filename	Size	Change
`./bundle/chunk-47IBHWBB.js`	0 B	-14.6 MB (removed)	🏆
`./bundle/chunk-AVLKHPC5.js`	0 B	-669 kB (removed)	🏆
`./bundle/chunk-GEHXKXQJ.js`	0 B	-3.43 kB (removed)	🏆
`./bundle/chunk-UZ5TYF7Z.js`	0 B	-2.73 MB (removed)	🏆
`./bundle/chunk-VSIOCFQH.js`	0 B	-3.8 kB (removed)	🏆
`./bundle/chunk-ZZQWEWOR.js`	0 B	-49.2 kB (removed)	🏆
`./bundle/core-DF3YXFQ2.js`	0 B	-47.4 kB (removed)	🏆
`./bundle/devtoolsService-EZXYI5WH.js`	0 B	-27.8 kB (removed)	🏆
`./bundle/gemini-XL3WLALG.js`	0 B	-578 kB (removed)	🏆
`./bundle/interactiveCli-BNUZ2WFS.js`	0 B	-1.29 MB (removed)	🏆
`./bundle/liteRtServerManager-YEOWMMKG.js`	0 B	-2.08 kB (removed)	🏆
`./bundle/oauth2-provider-SXZTOYIT.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-3DHIRO7H.js`	49.2 kB	+49.2 kB (new file)	🆕
`./bundle/chunk-5IXNA2YU.js`	14.6 MB	+14.6 MB (new file)	🆕
`./bundle/chunk-5NO6SJOB.js`	3.8 kB	+3.8 kB (new file)	🆕
`./bundle/chunk-B7IGFK4U.js`	2.73 MB	+2.73 MB (new file)	🆕
`./bundle/chunk-N4R763GF.js`	3.43 kB	+3.43 kB (new file)	🆕
`./bundle/chunk-YJRYCSCS.js`	669 kB	+669 kB (new file)	🆕
`./bundle/core-DEYXL2AT.js`	47.4 kB	+47.4 kB (new file)	🆕
`./bundle/devtoolsService-BJX7WBHV.js`	27.8 kB	+27.8 kB (new file)	🆕
`./bundle/gemini-ELH7W5LQ.js`	578 kB	+578 kB (new file)	🆕
`./bundle/interactiveCli-QLK636HT.js`	1.29 MB	+1.29 MB (new file)	🆕
`./bundle/liteRtServerManager-2XMJGFBD.js`	2.08 kB	+2.08 kB (new file)	🆕
`./bundle/oauth2-provider-O6WMWGI6.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/bundled/third_party/index.js`	8 MB	0 B
`./bundle/chunk-34MYV7JD.js`	2.45 kB	0 B
`./bundle/chunk-5AUYMPVF.js`	858 B	0 B
`./bundle/chunk-5PS3AYFU.js`	1.18 kB	0 B
`./bundle/chunk-664ZODQF.js`	124 kB	0 B
`./bundle/chunk-DAHVX5MI.js`	206 kB	0 B
`./bundle/chunk-IUUIT4SU.js`	56.5 kB	0 B
`./bundle/chunk-RJTRUG2J.js`	39.8 kB	0 B
`./bundle/chunk-UHHRGNIO.js`	1.97 MB	0 B
`./bundle/cleanup-EMA3ZJSE.js`	0 B	-932 B (removed)	🏆
`./bundle/devtools-36NN55EP.js`	696 kB	0 B
`./bundle/dist-T73EYRDX.js`	356 B	0 B
`./bundle/events-XB7DADIJ.js`	418 B	0 B
`./bundle/examples/hooks/scripts/on-start.js`	188 B	0 B
`./bundle/examples/mcp-server/example.js`	1.43 kB	0 B
`./bundle/gemini.js`	4.97 kB	0 B
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB	0 B
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB	0 B
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB	0 B
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB	0 B
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB	0 B
`./bundle/memoryDiscovery-CZURD35O.js`	980 B	0 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	222 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	229 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	13.4 kB	0 B
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB	0 B
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB	0 B
`./bundle/src-QVCVGIUX.js`	47 kB	0 B
`./bundle/start-TYOHETGR.js`	0 B	-622 B (removed)	🏆
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB	0 B
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB	0 B
`./bundle/cleanup-I433GP5G.js`	932 B	+932 B (new file)	🆕
`./bundle/start-PTV7N3G7.js`	622 B	+622 B (new file)	🆕

_{compressed-size-action}

gemini-code-assist

Code Review

This pull request updates the HintMessage, UserMessage, and UserShellMessage components to ensure background colors are only applied when explicitly defined in the theme. It also adds unit tests to verify that these components correctly handle the NO_COLOR environment variable. The review feedback correctly identifies that the new tests violate the repository's testing conventions by stubbing environment variables within individual test cases instead of using beforeEach and afterEach blocks for setup and cleanup.

jacob314

Summary

This PR successfully fixes the UI background color logic for user messages to properly account for environments without colored backgrounds (e.g., when NO_COLOR is set). It also appropriately addresses the previous review feedback by refactoring the tests to use beforeEach and afterEach blocks for environment variable stubbing (vi.stubEnv and vi.unstubAllEnvs), perfectly aligning with the repository's testing conventions.

Findings

Critical: None. Tests, linting, and type checks all pass locally without issues.
Improvements: None. The test setup is clean and the component logic is sound.
Nitpicks: None.

Conclusion

Approved. The implementation is solid and the testing hygiene is excellent. Ready to merge!

jacob314

…oogle-gemini#25880)

Fixed incorrect background color check

fed8521

devr0306 requested a review from a team as a code owner April 23, 2026 19:38

gemini-code-assist Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread packages/cli/src/ui/components/messages/HintMessage.test.tsx Outdated

Comment thread packages/cli/src/ui/components/messages/UserMessage.test.tsx Outdated

Comment thread packages/cli/src/ui/components/messages/UserShellMessage.test.tsx Outdated

devr0306 added 2 commits April 23, 2026 14:58

Refactored tests to be consistent with guidelines

f46ca1c

Updated to snapshots

8d241f2

jacob314 approved these changes Apr 23, 2026

View reviewed changes

devr0306 added this pull request to the merge queue Apr 23, 2026

Merged via the queue into main with commit 69150e8 Apr 23, 2026
27 checks passed

devr0306 deleted the no-color-message-padding branch April 23, 2026 21:42

kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026

fix(ui): corrected background color check in user message components (g…

361cd6c

…oogle-gemini#25880)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): corrected background color check in user message components#25880

fix(ui): corrected background color check in user message components#25880
devr0306 merged 3 commits intomainfrom
no-color-message-padding

devr0306 commented Apr 23, 2026

Uh oh!

gemini-code-assist Bot commented Apr 23, 2026

Uh oh!

github-actions Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacob314 left a comment

Uh oh!

jacob314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

devr0306 commented Apr 23, 2026

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist Bot commented Apr 23, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Summary

Findings

Conclusion

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 23, 2026 •

edited

Loading