Skip to content

fix(core): only show list suggestion if the partial input is empty#25821

Merged
cynthialong0-0 merged 1 commit intomainfrom
fix/command-autocomplete
Apr 23, 2026
Merged

fix(core): only show list suggestion if the partial input is empty#25821
cynthialong0-0 merged 1 commit intomainfrom
fix/command-autocomplete

Conversation

@cynthialong0-0
Copy link
Copy Markdown
Contributor

@cynthialong0-0 cynthialong0-0 commented Apr 22, 2026

Summary

Fixes a bug in the slash command autocomplete where the auto list suggestion (e.g./chat list) would incorrectly appear even when typing a non-matching partial word (e.g., /chat x). This ensures that the autocomplete suggestions are filtered correctly based on the user's input.

Details

  • Modified useCommandSuggestions in packages/cli/src/ui/hooks/useSlashCompletion.ts to only show the auto section suggestion (list) if the partial input is empty or matches the start of the word list.
  • Added unit tests in packages/cli/src/ui/hooks/useSlashCompletion.test.ts to verify the correct behavior for both non-matching and matching partial inputs after a top-level command like /chat

Related Issues

Fixes #23541

How to Validate

  1. Start the CLI.
  2. Type /chat (with a trailing space). You should see list under the auto section.
  3. Type /chat l. You should still see list.
  4. Type /chat x. You should not see list.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@cynthialong0-0 cynthialong0-0 marked this pull request as ready for review April 22, 2026 19:16
@cynthialong0-0 cynthialong0-0 requested a review from a team as a code owner April 22, 2026 19:16
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the CLI slash command autocomplete feature where the 'list' suggestion was incorrectly displayed regardless of the user's partial input. By implementing a conditional check, the system now properly filters this suggestion to improve the accuracy and relevance of the autocomplete experience.

Highlights

  • Autocomplete Logic Fix: Updated the slash command autocomplete logic to ensure the 'list' suggestion only appears when the partial input is empty or matches the start of the word 'list'.
  • Regression Testing: Added new unit tests to verify that the 'list' suggestion is correctly filtered based on user input, preventing it from appearing for non-matching partial words.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-gemini google-gemini deleted a comment from gemini-cli Bot Apr 22, 2026
@github-actions
Copy link
Copy Markdown

Size Change: +171 B (0%)

Total Size: 33.7 MB

Filename Size Change
./bundle/chunk-BHCSMO2M.js 0 B -676 kB (removed) 🏆
./bundle/chunk-CBGDO3UJ.js 0 B -2.72 MB (removed) 🏆
./bundle/chunk-H7SMYFKN.js 0 B -49.2 kB (removed) 🏆
./bundle/chunk-QQOJTOZQ.js 0 B -3.8 kB (removed) 🏆
./bundle/chunk-R3IAB5UC.js 0 B -3.43 kB (removed) 🏆
./bundle/chunk-TEEXSGE7.js 0 B -14.5 MB (removed) 🏆
./bundle/core-7MOZCXW7.js 0 B -46.8 kB (removed) 🏆
./bundle/devtoolsService-7CIRFMVT.js 0 B -28.4 kB (removed) 🏆
./bundle/gemini-FAIOI7UD.js 0 B -576 kB (removed) 🏆
./bundle/interactiveCli-ZLKO72IN.js 0 B -1.3 MB (removed) 🏆
./bundle/liteRtServerManager-6OYKAJVM.js 0 B -2.08 kB (removed) 🏆
./bundle/oauth2-provider-SX3G2LAH.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-DVGT7SCI.js 2.72 MB +2.72 MB (new file) 🆕
./bundle/chunk-M4TY456R.js 49.2 kB +49.2 kB (new file) 🆕
./bundle/chunk-P6OBQEYO.js 3.43 kB +3.43 kB (new file) 🆕
./bundle/chunk-U5MCTDJH.js 676 kB +676 kB (new file) 🆕
./bundle/chunk-UFYLYL2S.js 14.5 MB +14.5 MB (new file) 🆕
./bundle/chunk-URENFZ2O.js 3.8 kB +3.8 kB (new file) 🆕
./bundle/core-D4V7PHYI.js 46.8 kB +46.8 kB (new file) 🆕
./bundle/devtoolsService-YGLCWKWO.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/gemini-MS2GFIK2.js 576 kB +576 kB (new file) 🆕
./bundle/interactiveCli-BXLDT3YY.js 1.3 MB +1.3 MB (new file) 🆕
./bundle/liteRtServerManager-Y6EACZTP.js 2.08 kB +2.08 kB (new file) 🆕
./bundle/oauth2-provider-TTMMQOWK.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/bundled/third_party/index.js 8 MB 0 B
./bundle/chunk-2RHFUIH4.js 1.97 MB 0 B
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-5PS3AYFU.js 1.18 kB 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-5HY6BZ3I.js 0 B -932 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/events-XB7DADIJ.js 418 B 0 B
./bundle/examples/hooks/scripts/on-start.js 188 B 0 B
./bundle/examples/mcp-server/example.js 1.43 kB 0 B
./bundle/gemini.js 4.97 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-HWEYBJE7.js 980 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/start-KIEGS4AW.js 0 B -622 B (removed) 🏆
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-GRW5DNEI.js 932 B +932 B (new file) 🆕
./bundle/start-KNE4PQJG.js 622 B +622 B (new file) 🆕

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the slash command completion logic in the useSlashCompletion hook to filter the 'auto-list' suggestion based on the user's partial input. The 'list' suggestion is now only included if the input is empty or matches the label. New test cases have been added to useSlashCompletion.test.ts to ensure that the suggestion is correctly shown or hidden depending on the input. I have no feedback to provide.

@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality labels Apr 22, 2026
@cynthialong0-0 cynthialong0-0 added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit a007f64 Apr 23, 2026
34 checks passed
@cynthialong0-0 cynthialong0-0 deleted the fix/command-autocomplete branch April 23, 2026 14:20
kimjune01 pushed a commit to kimjune01/gemini-cli-claude that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete for subcommands duplicates the main command name

2 participants