Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates several keyboard shortcuts to improve usability and consistency. It migrates the 'open external editor' action to Ctrl+G and the 'show IDE context' action to F4. To ensure a smooth transition for users, a deprecation warning has been implemented for the old Ctrl+X shortcut, which now provides a helpful hint regarding the new binding. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: +1.07 kB (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request reassigns keyboard shortcuts, moving the external editor command to Ctrl+G and the IDE context detail command to F4. It also introduces a deprecation path for the previous Ctrl+X shortcut. Feedback suggests removing the deprecated command logic and associated hint messages entirely to avoid confusion, in accordance with repository policy. Additionally, the hardcoded shortcut in the UI should be replaced with a dynamic command formatter to ensure consistency with user configurations.
jacob314
left a comment
There was a problem hiding this comment.
I've regenerated the keyboard shortcuts documentation using npm run docs:keybindings and pushed the updated markdown file.
Warn about ctrl-x fix(cli): use formatCommand for shortcuts instead of hardcoded strings docs(cli): regenerate keyboard shortcuts documentation
Summary
Switch to ctrl-G to open in an external editor from ctrl-X
If users press ctrl-X we show a toast suggesting ctrl-G
Ctrl-G was a little used IDE integration debugging command. Moved that to F4.
Related Issues
Fixes #24860