Skip to content

feat(cli): switch to ctrl+g from ctrl-x#24861

Merged
jacob314 merged 1 commit intomainfrom
ctrl_g
Apr 8, 2026
Merged

feat(cli): switch to ctrl+g from ctrl-x#24861
jacob314 merged 1 commit intomainfrom
ctrl_g

Conversation

@jacob314
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 commented Apr 7, 2026

Summary

Switch to ctrl-G to open in an external editor from ctrl-X

If users press ctrl-X we show a toast suggesting ctrl-G

Ctrl-G was a little used IDE integration debugging command. Moved that to F4.

Related Issues

Fixes #24860

@jacob314 jacob314 requested review from a team as code owners April 7, 2026 23:17
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates several keyboard shortcuts to improve usability and consistency. It migrates the 'open external editor' action to Ctrl+G and the 'show IDE context' action to F4. To ensure a smooth transition for users, a deprecation warning has been implemented for the old Ctrl+X shortcut, which now provides a helpful hint regarding the new binding.

Highlights

  • Keyboard Shortcut Remapping: The shortcut to open the external editor has been updated from Ctrl+X to Ctrl+G, and the shortcut to show IDE context details has been updated from Ctrl+G to F4.
  • Deprecation Handling: Added a deprecated command handler for the old Ctrl+X shortcut that displays a hint to the user to use the new Ctrl+G shortcut instead.
  • Documentation and Testing: Updated all relevant documentation, UI components, test suites, and snapshots to reflect the new key bindings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Apr 7, 2026

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli Bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Size Change: +1.07 kB (0%)

Total Size: 34 MB

Filename Size Change
./bundle/chunk-FE3KRPAO.js 0 B -14.8 MB (removed) 🏆
./bundle/chunk-LBI7C6VN.js 0 B -3.15 MB (removed) 🏆
./bundle/core-TBOS5YRI.js 0 B -45.4 kB (removed) 🏆
./bundle/devtoolsService-4YRTMEYE.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-7ZZWPWMN.js 0 B -1.64 MB (removed) 🏆
./bundle/oauth2-provider-M3U2EYPF.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-EGWR5G5Z.js 3.15 MB +3.15 MB (new file) 🆕
./bundle/chunk-XHMQRMSY.js 14.8 MB +14.8 MB (new file) 🆕
./bundle/core-SWPQBTUW.js 45.4 kB +45.4 kB (new file) 🆕
./bundle/devtoolsService-CKFCE3M5.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-ZHYNZEK5.js 1.64 MB +1.64 MB (new file) 🆕
./bundle/oauth2-provider-VDJZDR3A.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/bundled/third_party/index.js 8 MB
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-5PS3AYFU.js 1.18 kB
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-Z34XA6FT.js 1.96 MB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-XB7DADIJ.js 418 B
./bundle/gemini.js 553 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-PYBLKP7S.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reassigns keyboard shortcuts, moving the external editor command to Ctrl+G and the IDE context detail command to F4. It also introduces a deprecation path for the previous Ctrl+X shortcut. Feedback suggests removing the deprecated command logic and associated hint messages entirely to avoid confusion, in accordance with repository policy. Additionally, the hardcoded shortcut in the UI should be replaced with a dynamic command formatter to ensure consistency with user configurations.

Comment thread packages/cli/src/ui/key/keyBindings.ts
Comment thread packages/cli/src/ui/key/keyBindings.ts
Comment thread packages/cli/src/ui/components/InputPrompt.tsx
Comment thread packages/cli/src/ui/components/InputPrompt.tsx Outdated
Comment thread packages/cli/src/ui/components/ExitPlanModeDialog.tsx Outdated
Comment thread packages/cli/src/ui/components/ContextSummaryDisplay.tsx Outdated
Comment thread docs/reference/keyboard-shortcuts.md Outdated
@jacob314 jacob314 changed the title Switch to ctrl+g from ctrl-x feat(cli): switch to ctrl+g from ctrl-x Apr 7, 2026
jacob314

This comment was marked as off-topic.

Copy link
Copy Markdown
Contributor Author

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've regenerated the keyboard shortcuts documentation using npm run docs:keybindings and pushed the updated markdown file.

Warn about ctrl-x

fix(cli): use formatCommand for shortcuts instead of hardcoded strings

docs(cli): regenerate keyboard shortcuts documentation
@jacob314 jacob314 enabled auto-merge April 8, 2026 05:53
@jacob314 jacob314 added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit cbacdc6 Apr 8, 2026
26 of 27 checks passed
@jacob314 jacob314 deleted the ctrl_g branch April 8, 2026 06:56
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to ctrl+G from ctrl+X for opening in an external editor

2 participants