Conversation
|
Hi @sripasg, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a help functionality to the Agent Client Protocol, improving user experience by allowing them to discover available commands directly within the interface. The implementation leverages the existing command registry to dynamically generate a list of commands, ensuring that the help output remains consistent with the current system state. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new /help command to the CLI, providing users with information on basic context usage and a list of available commands. A test case was added to verify the command's registration. Feedback suggests sorting the command list alphabetically to improve discoverability and usability as the number of commands grows.
|
Size Change: -898 B (0%) Total Size: 34 MB
ℹ️ View Unchanged
|
afd85f2 to
f8ffbaf
Compare
Add a /help command to the Agent Client Protocol (ACP) interface to list available commands and basic usage instructions, matching the TUI functionality. - Implement HelpCommand in packages/cli/src/acp/commands/help.ts. - Register the command in commandHandler.ts and pass the CommandRegistry to it. - Format the output using Markdown headers and bullet points for better rendering in chat interfaces. - Exclude the "shell mode" instruction from the help output as it is not yet fully supported in the ACP context. - Add unit tests for command parsing in commandHandler.test.ts.
f8ffbaf to
7bbb5be
Compare
|
/patch stable |
|
🚀 [Step 1/4] Patch workflow(s) waiting for approval! 📋 Details:
⏳ Status: The patch creation workflow has been triggered and is waiting for deployment approval. Please visit the specific workflow links below and approve the runs. 🔗 Track Progress: |
# Conflicts: # packages/cli/src/acp/commandHandler.test.ts # packages/cli/src/acp/commandHandler.ts
|
🚀 [Step 2/4] Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
Summary
Add a /help command to the Agent Client Protocol (ACP) interface to list available commands and basic usage instructions, matching the TUI functionality.
Details
Related Issues
Part of request from Jetbrains.
How to Validate
Should appear in / completion on ACP mode in IDE
Should list the help commands appropriate for the ACP
Pre-Merge Checklist