relax tool sandboxing overrides for plan mode to match defaults. by DavidAPierce · Pull Request #24762 · google-gemini/gemini-cli

DavidAPierce · 2026-04-06T18:03:28Z

Summary

This PR enables tool sandboxing to function correctly when writing plan files to the temporary session directory. It changes allowOverrides from false to true for modes.plan in the sandbox-default.toml policy.

Details

Previously, when tool sandboxing was enabled, modes.plan strictly prohibited any sandbox overrides. This unintentionally blocked the internal SandboxedFileSystemService from requesting the necessary write permissions to create and save .md plan files to the tmp session directory, causing operations in Plan Mode to fail with "Sandbox request rejected" errors.

By setting allowOverrides = true for plan mode, we allow internal tools that are already permitted by the Policy Engine (like write_file for plan files) to request the specific write overrides they need to function. The workspace itself remains read-only as defined by the policy, preserving the security posture.

Related Issues

Fixes #24750

How to Validate

Enable tool sandboxing in your settings or via environment variable (GEMINI_SANDBOX=docker).
Enter plan mode (/plan).
Ask the agent to plan a change.
Verify that the plan file is successfully written to the temporary session directory without any "Sandbox request rejected" errors.

Pre-Merge Checklist

gemini-code-assist · 2026-04-06T18:03:39Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the sandbox policy configuration to ensure that plan mode functions correctly when tool sandboxing is enabled. By relaxing the override restrictions, the system now permits internal services to perform necessary write operations to the temporary session directory while maintaining the overall security posture of the workspace.

Highlights

Sandbox Policy Update: Updated the sandbox-default.toml policy to set allowOverrides to true for plan mode.
Fixing Plan Mode Failures: Resolved an issue where tool sandboxing prevented the creation of plan files in the temporary session directory.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-04-06T18:06:54Z

Size Change: -5 B (0%)

Total Size: 34 MB

Filename	Size	Change
`./bundle/chunk-MN3FCVGY.js`	0 B	-3.15 MB (removed)	🏆
`./bundle/chunk-VN7XS4EK.js`	0 B	-14.8 MB (removed)	🏆
`./bundle/core-PX7UGXZO.js`	0 B	-45.2 kB (removed)	🏆
`./bundle/devtoolsService-WBKKPDRA.js`	0 B	-28.4 kB (removed)	🏆
`./bundle/interactiveCli-PVKNCILJ.js`	0 B	-1.64 MB (removed)	🏆
`./bundle/oauth2-provider-ETHL5MB2.js`	0 B	-9.16 kB (removed)	🏆
`./bundle/chunk-PMI74TD2.js`	3.15 MB	+3.15 MB (new file)	🆕
`./bundle/chunk-TBJ2PNPM.js`	14.8 MB	+14.8 MB (new file)	🆕
`./bundle/core-G4AZIX7B.js`	45.2 kB	+45.2 kB (new file)	🆕
`./bundle/devtoolsService-346HIOGG.js`	28.4 kB	+28.4 kB (new file)	🆕
`./bundle/interactiveCli-LCGGHNCI.js`	1.64 MB	+1.64 MB (new file)	🆕
`./bundle/oauth2-provider-3NHS5EM2.js`	9.16 kB	+9.16 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
`./bundle/bundled/third_party/index.js`	8 MB
`./bundle/chunk-34MYV7JD.js`	2.45 kB
`./bundle/chunk-5AUYMPVF.js`	858 B
`./bundle/chunk-5PS3AYFU.js`	1.18 kB
`./bundle/chunk-664ZODQF.js`	124 kB
`./bundle/chunk-DAHVX5MI.js`	206 kB
`./bundle/chunk-GFUOVHXW.js`	1.96 MB
`./bundle/chunk-IUUIT4SU.js`	56.5 kB
`./bundle/chunk-RJTRUG2J.js`	39.8 kB
`./bundle/devtools-36NN55EP.js`	696 kB
`./bundle/dist-T73EYRDX.js`	356 B
`./bundle/events-XB7DADIJ.js`	418 B
`./bundle/gemini.js`	552 kB
`./bundle/getMachineId-bsd-TXG52NKR.js`	1.55 kB
`./bundle/getMachineId-darwin-7OE4DDZ6.js`	1.55 kB
`./bundle/getMachineId-linux-SHIFKOOX.js`	1.34 kB
`./bundle/getMachineId-unsupported-5U5DOEYY.js`	1.06 kB
`./bundle/getMachineId-win-6KLLGOI4.js`	1.72 kB
`./bundle/memoryDiscovery-ACCRGPX3.js`	980 B
`./bundle/multipart-parser-KPBZEGQU.js`	11.7 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js`	222 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js`	229 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js`	13.4 kB
`./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js`	132 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB
`./bundle/sandbox-macos-strict-open.sb`	4.82 kB
`./bundle/sandbox-macos-strict-proxied.sb`	5.02 kB
`./bundle/src-QVCVGIUX.js`	47 kB
`./bundle/tree-sitter-7U6MW5PS.js`	274 kB
`./bundle/tree-sitter-bash-34ZGLXVX.js`	1.84 MB

_{compressed-size-action}

gemini-code-assist

Code Review

This pull request updates the default sandbox policy to allow overrides and removes an unnecessary blank line in the configuration. A review comment identifies that the hardcoded fallback configuration in sandboxPolicyManager.ts also needs to be updated to maintain consistency with these changes.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

…gle-gemini#24762)

relax overrides for plan mode to match defaults.

9c25200

DavidAPierce requested a review from a team as a code owner April 6, 2026 18:03

gemini-code-assist Bot reviewed Apr 6, 2026

View reviewed changes

Comment thread packages/core/src/policy/policies/sandbox-default.toml

jerop changed the title ~~relax overrides for plan mode to match defaults.~~ relax tool sandboxing overrides for plan mode to match defaults. Apr 6, 2026

DavidAPierce added 2 commits April 6, 2026 18:23

Address Default_Config not being in sync with updated config settings.

e90c818

Merge branch 'main' into sandbox_tmp_dir_plan_permissions

9b63b16

gemini-cli Bot added the area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt label Apr 6, 2026

ehedlund approved these changes Apr 6, 2026

View reviewed changes

DavidAPierce added this pull request to the merge queue Apr 6, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 6, 2026

jerop added this pull request to the merge queue Apr 6, 2026

Merged via the queue into main with commit 984f02c Apr 6, 2026
27 checks passed

jerop deleted the sandbox_tmp_dir_plan_permissions branch April 6, 2026 22:59

jerop mentioned this pull request Apr 8, 2026

Add integration tests for tool sandboxing with plans and tasks #24932

Closed

warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026

relax tool sandboxing overrides for plan mode to match defaults. (goo…

6691a53

…gle-gemini#24762)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

relax tool sandboxing overrides for plan mode to match defaults.#24762

relax tool sandboxing overrides for plan mode to match defaults.#24762
jerop merged 3 commits intomainfrom
sandbox_tmp_dir_plan_permissions

DavidAPierce commented Apr 6, 2026

Uh oh!

gemini-code-assist Bot commented Apr 6, 2026

Uh oh!

github-actions Bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

DavidAPierce commented Apr 6, 2026

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

gemini-code-assist Bot commented Apr 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 6, 2026 •

edited

Loading