Skip to content

fix(cli): refresh slash command list after /skills reload#24454

Merged
abhipatel12 merged 1 commit intomainfrom
fix/skills-reload-completion
Apr 1, 2026
Merged

fix(cli): refresh slash command list after /skills reload#24454
abhipatel12 merged 1 commit intomainfrom
fix/skills-reload-completion

Conversation

@NTaylorMullen
Copy link
Copy Markdown
Collaborator

Summary

Refresh the slash command completion list after running /skills reload.

Details

The /skills reload command reloaded the skills in the underlying configuration but failed to notify the UI to refresh its list of available slash commands. This resulted in the completion list being stale until some other event triggered a reload. This PR adds a call to context.ui.reloadCommands() in the reloadAction of skillsCommand.ts and updates the necessary mocks and tests.

Related Issues

N/A (Reported by user in session)

How to Validate

  1. Run the unit tests for skillsCommand:
    npm test -w @google/gemini-cli -- src/ui/commands/skillsCommand.test.ts
  2. Verify that context.ui.reloadCommands is called when /skills reload is executed.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

- Call context.ui.reloadCommands() in skills reloadAction

- Update mockCommandContext to include reloadCommands

- Add test expectation to verify reloadCommands is called
@NTaylorMullen NTaylorMullen requested a review from a team as a code owner April 1, 2026 19:01
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a synchronization issue where the slash command completion list would become stale after a user performed a skills reload. By explicitly triggering a UI command refresh upon completion of the reload action, the application ensures that the user interface correctly reflects the updated state of available skills.

Highlights

  • UI Synchronization: Added a call to context.ui.reloadCommands() within the skills reload action to ensure the slash command completion list remains accurate.
  • Test Coverage: Updated the mock command context and added a corresponding assertion in the skills command unit tests to verify the UI refresh trigger.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Size Change: +29 B (0%)

Total Size: 34.6 MB

Filename Size Change
./bundle/chunk-H2ZCRCF7.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-I6QMVCJW.js 0 B -3.82 MB (removed) 🏆
./bundle/core-5NRSFZ6T.js 0 B -44.8 kB (removed) 🏆
./bundle/devtoolsService-V7WOWUHP.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-2PKEXQPK.js 0 B -1.66 MB (removed) 🏆
./bundle/oauth2-provider-NS7ZVB56.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-BPVR2SEL.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-J3NFMZYK.js 3.82 MB +3.82 MB (new file) 🆕
./bundle/core-35Y5JBU3.js 44.8 kB +44.8 kB (new file) 🆕
./bundle/devtoolsService-IFCMCHL7.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-XILOH4WQ.js 1.66 MB +1.66 MB (new file) 🆕
./bundle/oauth2-provider-AJW5T624.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/bundled/third_party/index.js 8 MB
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-R5X4CMUM.js 1.96 MB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-U4FACSVX.js 1.13 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-CLX3JQHP.js 418 B
./bundle/gemini.js 533 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-VL3OH25S.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@abhipatel12 abhipatel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhipatel12 abhipatel12 enabled auto-merge April 1, 2026 19:06
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a reloadCommands method to the UI context, ensuring that commands are reloaded after a skill reload action. It includes updates to the mock command context and the skillsCommand test to verify this behavior. I have no feedback to provide.

@abhipatel12 abhipatel12 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 4e21e5b Apr 1, 2026
30 checks passed
@abhipatel12 abhipatel12 deleted the fix/skills-reload-completion branch April 1, 2026 19:28
kalenkevich pushed a commit to kalenkevich/gemini-cli that referenced this pull request Apr 3, 2026
afanty2021 pushed a commit to afanty2021/gemini-cli that referenced this pull request Apr 4, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants