fix(ui): wrap topic and intent fields in TopicMessage#24386
Conversation
4cd3ea6 to
c3e6e08
Compare
|
Size Change: +121 B (0%) Total Size: 26.5 MB
ℹ️ View Unchanged
|
c3e6e08 to
19cc8d5
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the presentation of topic and intent information within the UI. By enabling text wrapping and adjusting the separator format, the component now handles longer content gracefully, ensuring that critical information remains visible and readable to the user. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
- allow topic and intent fields to break to separate lines (when needed) - allow the intent field to wrap line to keep user informed of agent intentions
19cc8d5 to
7e07b8c
Compare
|
Overall, great pull request! The code perfectly aligns with the project guidelines, particularly by relying on Ink's built-in layout engine ( Observations:
Minor Notes (No Action Required):
The changes are solid and look ready to merge. |
There was a problem hiding this comment.
Code Review
This pull request updates the TopicMessage component to improve layout and text wrapping within the CLI. Key changes include adding flexWrap to the message container, enabling truncation for titles, and replacing the em dash separator with a colon for better readability. Associated tests and snapshots in ToolGroupMessage.test.tsx have been updated to align with these UI modifications. I have no feedback to provide.
Summary
Allows the Topic tool output (
TopicMessage) to break the topic and intent fields onto separate lines when needed, and wrap the intent field. This ensures the user stays informed of the agent's intentions even with long outputs.Details
TopicMessage.tsxto useflexWrap="wrap"on the container andwrap="wrap"on the intent text.—to:to better separate the topic and intent when wrapped.ToolGroupMessage.test.tsx.Related Issues
Fixes #24383
How to Validate
npm test -w @google/gemini-cli -- src/ui/components/messages/ToolGroupMessage.test.tsxto verify the snapshot updates.Pre-Merge Checklist