fix(core): enable mid-stream retries for all models and re-enable compression test#24302
fix(core): enable mid-stream retries for all models and re-enable compression test#24302gsquared94 merged 5 commits intomainfrom
Conversation
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user experience for slash command completion in the CLI and ensuring better test coverage. It enables a previously skipped integration test related to context compression and refactors the command completion logic to provide more intuitive behavior when navigating command hierarchies, particularly for parent commands that have subcommands. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -59 B (0%) Total Size: 26.5 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request enables interactive chat compression tests, updates copyright years to 2025, and implements a "prefix descent" feature for the /chat and /resume commands to improve subcommand discoverability. Feedback identifies a compilation error due to the removal of a required React type import, a regression in trailing space logic for executable commands, and a logic flaw in the prefix descent implementation that could hide matching commands without subcommands.
c8ffffd to
852e819
Compare
Summary
This PR enables universal mid-stream content error retries (e.g.,
MALFORMED_FUNCTION_CALL) for all model families and re-enables the previously skipped context compression interactive test.Details
isGemini2Model) for structural streaming error retries inGeminiChatandGeminiClient. This ensures that Gemini 3 and future model families can "self-heal" from transient formatting glitches by retrying with an increased temperature.should trigger chat compression with /compress commandtest inintegration-tests/context-compress-interactive.test.ts. This test now passes reliably thanks to the enabled retry logic for Gemini 3.Related Issues
None.
How to Validate
Pre-Merge Checklist