Skip to content

fix(core): enable mid-stream retries for all models and re-enable compression test#24302

Merged
gsquared94 merged 5 commits intomainfrom
enable-compression-test
Mar 31, 2026
Merged

fix(core): enable mid-stream retries for all models and re-enable compression test#24302
gsquared94 merged 5 commits intomainfrom
enable-compression-test

Conversation

@sehoon38
Copy link
Copy Markdown
Contributor

@sehoon38 sehoon38 commented Mar 31, 2026

Summary

This PR enables universal mid-stream content error retries (e.g., MALFORMED_FUNCTION_CALL) for all model families and re-enables the previously skipped context compression interactive test.

Details

  • Universal Retries: Removed model-specific whitelisting (isGemini2Model) for structural streaming error retries in GeminiChat and GeminiClient. This ensures that Gemini 3 and future model families can "self-heal" from transient formatting glitches by retrying with an increased temperature.
  • Test Fix: Re-enabled the should trigger chat compression with /compress command test in integration-tests/context-compress-interactive.test.ts. This test now passes reliably thanks to the enabled retry logic for Gemini 3.
  • Cleanup: Removed unused model utility imports in the core package.

Related Issues

None.

How to Validate

npm run test:integration:sandbox:none -- integration-tests/context-compress-interactive.test.ts

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@sehoon38 sehoon38 requested a review from a team as a code owner March 31, 2026 03:18
@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli Bot commented Mar 31, 2026

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the user experience for slash command completion in the CLI and ensuring better test coverage. It enables a previously skipped integration test related to context compression and refactors the command completion logic to provide more intuitive behavior when navigating command hierarchies, particularly for parent commands that have subcommands.

Highlights

  • Test Re-enablement: Re-enabled the previously skipped integration test 'should trigger chat compression with /compress command' to ensure it is included in the standard test suite.
  • Slash Command Completion UX: Improved the slash command completion experience by allowing unique prefix descent for commands like /chat and /resume, enabling faster access to subcommands.
  • Refactored Completion Logic: Simplified the logic for adding trailing spaces after command completion and updated the command parser to better handle parent command descent.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

Size Change: -59 B (0%)

Total Size: 26.5 MB

Filename Size Change
./bundle/chunk-OJOW2KAX.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-Q2346Z5O.js 0 B -3.78 MB (removed) 🏆
./bundle/core-W3ZCID7T.js 0 B -44.6 kB (removed) 🏆
./bundle/devtoolsService-VHWYTOEO.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-OUBGRDUC.js 0 B -1.66 MB (removed) 🏆
./bundle/oauth2-provider-DT5WWMCM.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-Y6NXXUIZ.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/chunk-ZRD4NJR2.js 3.78 MB +3.78 MB (new file) 🆕
./bundle/core-B22G3QZN.js 44.6 kB +44.6 kB (new file) 🆕
./bundle/devtoolsService-U7SFGS2H.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-DNEBVK3G.js 1.66 MB +1.66 MB (new file) 🆕
./bundle/oauth2-provider-QMZBB3KE.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-PTGY7UXW.js 1.96 MB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-U4FACSVX.js 1.13 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-CLX3JQHP.js 418 B
./bundle/gemini.js 532 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-4PHRORYM.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables interactive chat compression tests, updates copyright years to 2025, and implements a "prefix descent" feature for the /chat and /resume commands to improve subcommand discoverability. Feedback identifies a compilation error due to the removal of a required React type import, a regression in trailing space logic for executable commands, and a logic flaw in the prefix descent implementation that could hide matching commands without subcommands.

Comment thread packages/cli/src/ui/hooks/useCommandCompletion.tsx
Comment thread packages/cli/src/ui/hooks/useCommandCompletion.tsx
Comment thread packages/cli/src/ui/hooks/useSlashCompletion.ts Outdated
@sehoon38 sehoon38 force-pushed the enable-compression-test branch from c8ffffd to 852e819 Compare March 31, 2026 03:25
@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 31, 2026
@sehoon38 sehoon38 changed the title test: enable context compression interactive test fix(core): enable universal mid-stream retries and re-enable compression test Mar 31, 2026
@sehoon38 sehoon38 changed the title fix(core): enable universal mid-stream retries and re-enable compression test fix(core): enable mid-stream retries for all models and re-enable compression test Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsquared94 gsquared94 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 561418c Mar 31, 2026
29 checks passed
@gsquared94 gsquared94 deleted the enable-compression-test branch March 31, 2026 06:42
theerud pushed a commit to theerud/gemini-cli that referenced this pull request Mar 31, 2026
kalenkevich pushed a commit to kalenkevich/gemini-cli that referenced this pull request Apr 3, 2026
afanty2021 pushed a commit to afanty2021/gemini-cli that referenced this pull request Apr 4, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants