Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant usability enhancement to the CLI's input prompt by implementing a scrollable interface for multi-line inputs. Previously, long inputs might have been difficult to navigate; now, a scrollbar appears automatically when the input exceeds the visible area, allowing users to easily review and edit extensive commands or text. This change is configurable via a new ui.scrollableInputPrompt setting, providing flexibility for user preferences. The underlying rendering mechanism has been modernized to support this functionality, ensuring a smoother and more intuitive user experience. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +3.23 kB (+0.01%) Total Size: 34 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces a scrollable input prompt, a great usability improvement for handling multi-line inputs. The implementation refactors the InputPrompt to use a new ScrollableList component, which is a solid architectural change.
My review has identified a few issues:
- A critical bug where the default value for the new
scrollableInputPromptsetting is inconsistent across the codebase. - Two instances of a React anti-pattern where state is updated directly during the render cycle in
text-buffer.tsandVirtualizedList.tsx. While this may be an attempt to avoid UI lag, it violates React's principles and can lead to maintainability issues. I've suggested refactoring these to useuseEffect.
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
17526ea to
7badb2d
Compare
Issues: background color for the input prompt Option to hide the scrollbar doesn't really work. fix: resolve build and test errors after rebase docs: regenerate settings docs and schema
7badb2d to
d837207
Compare
Issues: background color for the input prompt
Option to hide the scrollbar doesn't really work.
To test, create a large input prompt. Verify that if you are in alternate buffer or mouse mode (ctrl-S) the input prompt is scrollable.
Fixes #21423
Video:
https://screencast.googleplex.com/cast/NDkyNzkwODg5OTQ1NDk3NnxmM2U5MTY2Yy0yNg