feat(core): experimental in-progress steering hints (2 of 2)#19307
Conversation
|
Hi @joshualitt, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @joshualitt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the interactive capabilities of the Gemini CLI by introducing a robust system for in-progress model steering. Users can now provide real-time hints to guide the model's actions, allowing for more flexible and responsive interactions. The changes span UI, core logic, and system prompts, ensuring a cohesive and functional implementation of this new feature. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request implements the second part of the experimental in-progress steering hints feature, allowing users to guide the AI model mid-task. The changes are comprehensive, spanning the UI, core logic, and testing infrastructure.
Key changes include:
- A new mechanism in the UI to capture user input as 'hints' while the agent is active.
- Updates to the core agent execution logic to inject these hints into the model's context at appropriate times.
- A new mandate in the system prompt to instruct the model on how to interpret and act on these steering hints.
- New evaluation and integration tests to validate the correctness of corrective and suggestive hint scenarios.
I've reviewed the implementation for hint capture, storage, and injection, and the logic appears sound and well-integrated. The distinction in handling hints for local versus remote agents is logical. The new tests provide good coverage for this complex feature. I did not find any issues that meet the 'high' or 'critical' severity criteria. The code quality is high, and the feature seems well-implemented.
|
Size Change: +11 kB (+0.04%) Total Size: 24.5 MB
ℹ️ View Unchanged
|
c8bb6e9 to
bb01662
Compare
6dbd17f to
300d58d
Compare
e63ebec to
40712b8
Compare
This is a rebase / refactor of: Part of a series to address issue #18782
40712b8 to
6893fae
Compare
6893fae to
f9891ff
Compare
This is a rebase / refactor of: #18783
Part of a series to address issue #18782