Skip to content

Re-enable test.#11628

Merged
cornmander merged 1 commit intomainfrom
fix-11336
Oct 23, 2025
Merged

Re-enable test.#11628
cornmander merged 1 commit intomainfrom
fix-11336

Conversation

@cornmander
Copy link
Copy Markdown
Contributor

@cornmander cornmander commented Oct 22, 2025 •
edited
Loading

Fixes #11336

@cornmander cornmander requested a review from a team as a code owner October 22, 2025 00:48
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Oct 22, 2025

Summary of Changes

Hello @cornmander, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on reactivating a previously skipped integration test. By re-enabling the test that verifies the rejection of commands not on the allowlist, the change aims to improve the overall test coverage and bolster confidence in the system's security and command execution policies.

Highlights

  • Test Re-enablement: The integration test titled 'should reject commands not on the allowlist' located in integration-tests/run_shell_command.test.ts has been re-enabled by removing the .skip modifier, ensuring it runs as part of the test suite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables a previously skipped integration test for the run_shell_command tool. The test, should reject commands not on the allowlist, is now active, which improves test coverage by verifying that the tool correctly rejects shell commands that are not explicitly permitted. The change is straightforward and correct.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 22, 2025

Size Change: -2 B (0%)

Total Size: 20.1 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 20.1 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@cornmander cornmander requested a review from jacob314 October 22, 2025 01:01
@cornmander cornmander enabled auto-merge October 22, 2025 01:02
@cornmander
Copy link
Copy Markdown
Contributor Author

cornmander commented Oct 23, 2025

The deflake run (5x run on GHA) succeeded: https://github.com/google-gemini/gemini-cli/actions/runs/18728343588

@cornmander cornmander added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit bde5d61 Oct 23, 2025
20 checks passed
@cornmander cornmander deleted the fix-11336 branch October 23, 2025 14:01
thacio added a commit to thacio/auditaria that referenced this pull request Oct 23, 2025
@thacio
Merge Commit 'bde5d61': Re-enable test. (google-gemini#11628)
6c42ef7
cocosheng-g pushed a commit that referenced this pull request May 6, 2026
@cornmander
Re-enable test. (#11628)
371289b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skeshive skeshive skeshive approved these changes

@jacob314 jacob314 Awaiting requested review from jacob314

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-enable run_shell_command.test.ts > run_shell_command > should reject commands not on the allowlist

2 participants

@cornmander @skeshive