Delete unworkable replace test and enabled the rest#11125
Merged
Conversation
|
Size Change: -2 B (0%) Total Size: 17.9 MB ℹ️ View Unchanged
|
4876ef7 to
bd1ba40
Compare
bd1ba40 to
f54a3e2
Compare
bdmorgan
approved these changes
Oct 14, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 15, 2025
Millsondylan
pushed a commit
to Millsondylan/gemini-cli-1
that referenced
this pull request
Oct 19, 2025
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Deleted an unfixable test and re-enabled the rest which I ran 15 times each yielding only one failure (without retries).
Also: skip flakey json test.
Dive Deeper
The "'should fail safely when old_string is not found" was fundamentally unworkable since the internal error correction in the edit tool will occasionally try to "correct" the tool call by replacing the entire contents of the file yielding a "success" tool call.
Linked issues / bugs
Fixes #10916