Fix hooks to avoid unnecessary re-renders#10820
Merged
Merged
Conversation
|
Size Change: +562 B (0%) Total Size: 17.7 MB ℹ️ View Unchanged
|
richieforeman
approved these changes
Oct 9, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 9, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
cocosheng-g
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
These hooks were not properly memoized and it was causing unnecessary re-renders.
Dive Deeper
Normally, this is not a super big deal but I spotted it while investigating #10517
Reviewer Test Plan
Basic smoke test is sufficient. This is a pure refactor.
Linked issues / bugs
Contributes to #10517