Skip to content

test: assert 3rd party reexports#987

Merged
antongolub merged 1 commit intogoogle:mainfrom
c1825846:main
Dec 15, 2024
Merged

test: assert 3rd party reexports#987
antongolub merged 1 commit intogoogle:mainfrom
c1825846:main

Conversation

@c1825846
Copy link
Copy Markdown
Contributor

@c1825846 c1825846 commented Dec 14, 2024

Closes #979

  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Copy Markdown
Collaborator

Hey, @c1825846,

Could you sign the CLA plz?

@c1825846 c1825846 changed the title test: assert 3rd party reexports\ncloses #979 test: assert 3rd party reexportscloses #979 Dec 15, 2024
@c1825846 c1825846 changed the title test: assert 3rd party reexportscloses #979 test: assert 3rd party reexports closes #979 Dec 15, 2024
@c1825846 c1825846 force-pushed the main branch 2 times, most recently from 8d0c46b to 3c72f4d Compare December 15, 2024 12:39
@c1825846
Copy link
Copy Markdown
Contributor Author

Hey, @c1825846,

Could you sign the CLA plz?

done

@c1825846 c1825846 changed the title test: assert 3rd party reexports closes #979 test: assert 3rd party reexports Dec 15, 2024
Copy link
Copy Markdown
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c1825846 c1825846 requested a review from antongolub December 15, 2024 13:07
Copy link
Copy Markdown
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted. Thanks for the contribution.

@antongolub antongolub merged commit 14ff473 into google:main Dec 15, 2024
easymikey pushed a commit to easymikey/zx that referenced this pull request Dec 15, 2024
antongolub added a commit to antongolub/zx that referenced this pull request Dec 18, 2024
antongolub added a commit to antongolub/zx that referenced this pull request Dec 18, 2024
antongolub added a commit that referenced this pull request Dec 18, 2024
* test: merge autogenerated vendor tests

continues #987

* test: optimize test flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: assert 3rd party reexports

2 participants