Skip to content

Add async generator logic to ProcessPromise#984

Merged
antongolub merged 1 commit intogoogle:mainfrom
mxmvshnvsk:async-generator
Dec 15, 2024
Merged

Add async generator logic to ProcessPromise#984
antongolub merged 1 commit intogoogle:mainfrom
mxmvshnvsk:async-generator

Conversation

@mxmvshnvsk
Copy link
Contributor

@mxmvshnvsk mxmvshnvsk commented Dec 14, 2024

Fixes #965

@google-cla
Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mxmvshnvsk mxmvshnvsk force-pushed the async-generator branch 7 times, most recently from f50d90b to 1d65ba2 Compare December 15, 2024 20:43
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Thanks for your efforts.

@antongolub antongolub merged commit 3841cbe into google:main Dec 15, 2024
@mxmvshnvsk mxmvshnvsk deleted the async-generator branch December 15, 2024 21:04
antongolub added a commit to antongolub/zx that referenced this pull request Dec 17, 2024
@antongolub antongolub mentioned this pull request Dec 17, 2024
2 tasks
antongolub added a commit to antongolub/zx that referenced this pull request Dec 17, 2024
antongolub added a commit that referenced this pull request Dec 17, 2024
antongolub added a commit to antongolub/zx that referenced this pull request Feb 17, 2025
antongolub added a commit to antongolub/zx that referenced this pull request Feb 17, 2025
antongolub added a commit that referenced this pull request Feb 17, 2025
* feat: make `ProcessOutput` iterable

closes #1053
closes #1027

superseds #1088
relates #984

* refactor: reuse iterators logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: make ProcessPromise iterable via async for

3 participants