Skip to content

build(jsr): hide cli.ts#1188

Closed
easymikey wants to merge 8 commits intogoogle:mainfrom
easymikey:fix-cli-import
Closed

build(jsr): hide cli.ts#1188
easymikey wants to merge 8 commits intogoogle:mainfrom
easymikey:fix-cli-import

Conversation

@easymikey
Copy link
Contributor

Fix this https://github.com/google/zx/actions/runs/14338858804/job/40192915035

Сouldn't fix it. We are waiting for fix on the jsr side

@antongolub

@easymikey easymikey changed the title Fix cli import build(jsr): hide cli.ts Apr 8, 2025
antongolub added a commit to antongolub/zx that referenced this pull request Apr 8, 2025
@antongolub antongolub mentioned this pull request Apr 8, 2025
2 tasks
antongolub added a commit to antongolub/zx that referenced this pull request Apr 8, 2025
antongolub added a commit that referenced this pull request Apr 8, 2025
@antongolub
Copy link
Collaborator

@easymikey
Copy link
Contributor Author

@easymikey, https://jsr.io/@webpod/zx@8.5.2

It turned out that the jsr.json file was not downloaded to the client and VERSION is always undefined. May be add VERSION on the build stage (replace function to static constant)?

@antongolub
Copy link
Collaborator

Should we put jsr.json here?

"publish": {
    "include": [
      "src",
      "README.md",
      "LICENSE"
    ]
  },

@easymikey
Copy link
Contributor Author

easymikey commented Apr 9, 2025

Should we put jsr.json here?

"publish": {
    "include": [
      "src",
      "README.md",
      "LICENSE"
    ]
  },

Can try. But I'm pretty sure that it doesn't work because jsr.json is published by default. https://jsr.io/@webpod/zx/8.5.2/jsr.json.

I create config.json in src folder. Can you publish dev version ?

@antongolub

@antongolub
Copy link
Collaborator

Got this: jsr uses urls as module refs. #1193

import {VERSION} from 'jsr:@webpod/zx@8.5.2-dev.79a944b'

console.log('version', VERSION)

@easymikey
Copy link
Contributor Author

Got this: jsr uses urls as module refs. #1193

import {VERSION} from 'jsr:@webpod/zx@8.5.2-dev.79a944b'

console.log('version', VERSION)

Genius. Work fine!

@easymikey easymikey closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants