feat(log): enhance cmd highlighter and make it configurable#1122
Merged
antongolub merged 6 commits intogoogle:mainfrom Mar 10, 2025
Merged
feat(log): enhance cmd highlighter and make it configurable#1122antongolub merged 6 commits intogoogle:mainfrom
antongolub merged 6 commits intogoogle:mainfrom
Conversation
499a2c4 to
6cb77ca
Compare
|
It looks good to me, although I haven't checked out the code to do any testing on my own. It might be worth checking how these are colored: echo test > filepath
echo test >> filepath
echo test 2> filepath
echo test &> filepath
echo test &>> filepath
echo test >& filepath
echo 1+2 | bc
bc < filepathMaybe overly complicated: cat << 'EOF' | tee -a filepath
line 1
line 2
EOF |
Collaborator
Author
|
antonmedv
approved these changes
Mar 10, 2025
antongolub
added a commit
to antongolub/zx
that referenced
this pull request
Mar 10, 2025
2 tasks
antonmedv
pushed a commit
that referenced
this pull request
Mar 10, 2025
* feat(log): provide custom formatting for every entry kind continues #1122 * chore: ignore unknown log entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
formatCmdhelper to properly highlight cmds and their paramslogmodulelog.formatCmdlog.outputlog()testscloses #1119
@antonmedv
@stefansundin
Could you plz provide more examples
as isvsto be.