Add IntoByteSlice trait, use as bound for into_ref#966
Merged
Conversation
Add `IntoByteSlice` and `IntoByteSliceMut` traits, which extend `ByteSlice` and `ByteSliceMut`, adding `Into<&[u8]>` and `Into<&mut [u8]>` bounds respectively. Use these new traits as the bounds in the `Ref` methods `into_ref`, `into_mut`, `into_slice`, and `into_mut_slice`. This allows us to remove the post-monomorphization error which was originally added to patch the soundness hole in #716 in a backwards-compatible way. Closes #758
jswrenn
approved these changes
Feb 29, 2024
joshlf
added a commit
that referenced
this pull request
Mar 2, 2024
We made them obsolete in #966 by making the relevant errors not expressible in our API instead of using post-monomorphization errors.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
We made them obsolete in #966 by making the relevant errors not expressible in our API instead of using post-monomorphization errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
IntoByteSliceandIntoByteSliceMuttraits, which extendByteSliceandByteSliceMut, addingInto<&[u8]>andInto<&mut [u8]>bounds respectively. Use these new traits as the bounds in theRefmethodsinto_ref,into_mut,into_slice, andinto_mut_slice. This allows us to remove the post-monomorphization error which was originally added to patch the soundness hole in #716 in a backwards-compatible way.Closes #758