Skip to content

Re-enable test_new_error() for i686 target#42

Merged
joshlf merged 1 commit intogoogle:mainfrom
frazar:remove-stray-todo
Oct 10, 2022
Merged

Re-enable test_new_error() for i686 target#42
joshlf merged 1 commit intogoogle:mainfrom
frazar:remove-stray-todo

Conversation

@frazar
Copy link
Contributor

@frazar frazar commented Oct 10, 2022

The test_new_error() test was disabled for i686 due to Issue #21. This issue has since been fixed in #28, but the test was not re-enabled.

The test_new_error() test was disabled for i686 due to Issue google#21. This
issue has since been fixed in google#28, but the test was not re-enabled.
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks!

@joshlf joshlf merged commit c5af8fe into google:main Oct 10, 2022
@frazar frazar deleted the remove-stray-todo branch October 11, 2022 20:32
joshlf pushed a commit that referenced this pull request Aug 3, 2023
The test_new_error() test was disabled for i686 due to Issue #21. This
issue has since been fixed in #28, but the test was not re-enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants