In test_ptr_try_cast_into_soundness, skip u128/i128#3178
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G3rwwdyu7l7jtpdzzu2rjltonfg52yu3b #3178 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6067 6067
==================================================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ca6768 to
1de3831
Compare
jswrenn
approved these changes
Mar 31, 2026
These account for the majority of the time to execute this set of tests under Miri, which in turn accounts for the majority of the time to execute all tests in the merge queue. Worse, they often represent a significant long tail which cannot be parallelized (in other words, most time spent executing Miri tests – even on our current, 64-core runners – is spent after all *other* test cases have completed and the `u128` and `i128` cases are the only ones remaining, leaving all but 2 cores idle). Compre [1] (manually triggered based on the content of the parent commit), which took 28m46s with 12m4s for the "Build Docker image" step (which runs before the matrix) with [2] (manually triggered based on the content of this commit), which took 17m59s with 8m38s for the "Build Docker image" step. This is a savings of: (28m46s - 12m4s) - (17m59s - 8m38s) = 7m21s [1] https://github.com/google/zerocopy/actions/runs/23779309303 [2] https://github.com/google/zerocopy/actions/runs/23780205408 gherrit-pr-id: G6ytk3lhfbvylhux6xf5jzx3rzscgi56u
1de3831 to
b298c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These account for the majority of the time to execute this set of tests
under Miri, which in turn accounts for the majority of the time to
execute all tests in the merge queue. Worse, they often represent a
significant long tail which cannot be parallelized (in other words, most
time spent executing Miri tests – even on our current, 64-core runners
– is spent after all other test cases have completed and the
u128and
i128cases are the only ones remaining, leaving all but 2 coresidle).
Compre [1] (manually triggered based on the content of the parent
commit), which took 28m46s with 12m4s for the "Build Docker image" step
(which runs before the matrix) with [2] (manually triggered based on the
content of this commit), which took 17m59s with 8m38s for the "Build
Docker image" step. This is a savings of:
(28m46s - 12m4s) - (17m59s - 8m38s) = 7m21s
[1] https://github.com/google/zerocopy/actions/runs/23779309303
[2] https://github.com/google/zerocopy/actions/runs/23780205408
test_ptr_try_cast_into_soundness, skipu128/i128#3178Latest Update: v4 — Compare vs v3
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G6ytk3lhfbvylhux6xf5jzx3rzscgi56u && git checkout -b pr-G6ytk3lhfbvylhux6xf5jzx3rzscgi56u FETCH_HEADCheckout
git fetch origin refs/heads/G6ytk3lhfbvylhux6xf5jzx3rzscgi56u && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G6ytk3lhfbvylhux6xf5jzx3rzscgi56u && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.