[hermes] Initial commit#3144
Merged
Merged
Conversation
In order to support multiple `xxx.yml` GitHub Actions workflow files *which block CI*, update `ci/check_job_dependencies.sh` to operate per-file rather than over all `.yml` files. In particular, within each `.yml` file, if that file contains an `all-jobs-succeed` job, the script fails if that job does not depend on all *other* jobs in the file. This allows us to add a separate `hermes.yml` file with its own `all-jobs-succeed` job. In order to support `.github/auto-approvers.json` naming a specific file, update `ci/validate_auto_approvers.py` to support files in addition to directories. gherrit-pr-id: Ggo347ehkenkgzi5ijiiqgoufqukiq2jx
c3c4b3b to
7eced95
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6067 6067
=======================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support multiple
xxx.ymlGitHub Actions workflow fileswhich block CI, update
ci/check_job_dependencies.shto operateper-file rather than over all
.ymlfiles. In particular, within each.ymlfile, if that file contains anall-jobs-succeedjob, the scriptfails if that job does not depend on all other jobs in the file. This
allows us to add a separate
hermes.ymlfile with its ownall-jobs-succeedjob.In order to support
.github/auto-approvers.jsonnaming a specificfile, update
ci/validate_auto_approvers.pyto support files inaddition to directories.
Latest Update: v2 — Compare vs v1
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Ggo347ehkenkgzi5ijiiqgoufqukiq2jx && git checkout -b pr-Ggo347ehkenkgzi5ijiiqgoufqukiq2jx FETCH_HEADCheckout
git fetch origin refs/heads/Ggo347ehkenkgzi5ijiiqgoufqukiq2jx && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Ggo347ehkenkgzi5ijiiqgoufqukiq2jx && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.