[ci] In auto-approve, concatenate JSON arrays#3141
Merged
Conversation
The `validate_auto_approvers.py` script expects a single JSON array. When GitHub API results are paginated, returning multiple JSON arrays, this breaks that script unless we first concatenate them before passing them to the script. gherrit-pr-id: Glejkxn6s2idc57zgeyxhqk7tmqk3sphy
jswrenn
approved these changes
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3141 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6067 6067
=======================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate_auto_approvers.pyscript expects a single JSON array.When GitHub API results are paginated, returning multiple JSON arrays,
this breaks that script unless we first concatenate them before passing
them to the script.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Glejkxn6s2idc57zgeyxhqk7tmqk3sphy && git checkout -b pr-Glejkxn6s2idc57zgeyxhqk7tmqk3sphy FETCH_HEADCheckout
git fetch origin refs/heads/Glejkxn6s2idc57zgeyxhqk7tmqk3sphy && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Glejkxn6s2idc57zgeyxhqk7tmqk3sphy && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.