Expect stable_features lint for stable SIMD types#2584
Merged
Conversation
2 tasks
Previously, x86 AVX-12 SIMD types were gated by the unstable `stdarch_x86_avx512` feature. As of this writing, that feature has been stabilized on 1.89.0-nightly, staged for inclusion in 1.89.0 when it is released as stable. This means that the `simd-nightly` Cargo feature, which gates `stdarch_x86_avx512`, will now cause the `stable_features` lint to trigger when compiling on x86. This commit enables `expect(stable_features)` when compiling with `simd-nightly` for x86. Once 1.89.0 is released as stable, we will follow up with a commit which uses version detection to enable support for AVX-12 types, and we will remove our use of the `stdarch_x86_avx512` feature entirely. Makes progress on #2583 gherrit-pr-id: I7772b004a30ead788978e194181306fb98e092fa
fe8b242 to
d2ba384
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2584 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 20 20
Lines 5312 5312
=======================================
Hits 4723 4723
Misses 589 589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, x86 AVX-12 SIMD types were gated by the unstable
stdarch_x86_avx512feature. As of this writing, that feature has beenstabilized on 1.89.0-nightly, staged for inclusion in 1.89.0 when it is
released as stable.
This means that the
simd-nightlyCargo feature, which gatesstdarch_x86_avx512, will now cause thestable_featureslint totrigger when compiling on x86.
This commit enables
expect(stable_features)when compiling withsimd-nightlyfor x86. Once 1.89.0 is released as stable, we willfollow up with a commit which uses version detection to enable support
for AVX-12 types, and we will remove our use of the
stdarch_x86_avx512feature entirely.
Makes progress on #2583
This PR is on branch simd-nightly-avx12.
stable_featureslint for stable SIMD types #2584